You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2007/10/11 23:14:24 UTC

DO NOT REPLY [Bug 43605] New: - No page-number-citation in FOEventHandler

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43605>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43605

           Summary: No page-number-citation in FOEventHandler
           Product: Fop
           Version: 0.94
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: fo tree
        AssignedTo: fop-dev@xmlgraphics.apache.org
        ReportedBy: vschappert@bloomberg.net


There is no support for page-number-citation and page-number-citation-last in
FOEventHandler.  This is because of the following relatively simple omissions:

(1) org.apache.fop.fo.FOEventHandler :
       o   needs empty method startPageNumberCitation(PageNumberCitation)
       o   needs empty method endPageNumberCitation(PageNumberCitation)
       o   needs empty method startPageNumberCitationLast(PageNumberCitationLast)
       o   needs empty method endPageNumberCitationLast(PageNumberCitationLast)
(2) org.apache.fop.fo.flow.PageNumberCitation:
       o   method startOfNode() needs to call
getFOEventHandler().startPageNumberCitation(this);
       o   method endOfNode() needs to call
getFOEventHandler().endPageNumberCitation(this);
(3) org.apache.fop.fo.flow.PageNumberCitationLast:
       o   method startOfNode() needs to call
getFOEventHandler().startPageNumberCitationLast(this);
       o   method endOfNode() needs to call
getFOEventHandler().endPageNumberCitationLast(this);

The fixes are trivial (simply add about 15 missing lines as directed above).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 43605] - [PATCH] No page-number-citation in FOEventHandler

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43605>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43605


jeremias@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From jeremias@apache.org  2007-11-18 08:58 -------
Patch applied to FOP Trunk, thanks:
http://svn.apache.org/viewvc?rev=596097&view=rev

However, I had to modify the patch since it had a bug. See the commit message
for details.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 43605] - [PATCH] No page-number-citation in FOEventHandler

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43605>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43605


vschappert@bloomberg.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|No page-number-citation in  |[PATCH] No page-number-
                   |FOEventHandler              |citation in FOEventHandler




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 43605] - No page-number-citation in FOEventHandler

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43605>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43605


vschappert@bloomberg.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |43606
              nThis|                            |




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 43605] - No page-number-citation in FOEventHandler

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43605>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43605





------- Additional Comments From vschappert@bloomberg.net  2007-10-11 16:52 -------
Created an attachment (id=20966)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20966&action=view)
Adds support for page-number-citation etc. to FOEventHandler...

This patch should completely resolve the bug -- it is relatively
straightforward.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.