You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2023/01/17 13:29:13 UTC
[GitHub] [incubator-seatunnel] 2000liux opened a new issue, #3971: [Feature][connector-cdc] Configuration-related optimization suggestions
2000liux opened a new issue, #3971:
URL: https://github.com/apache/incubator-seatunnel/issues/3971
### Search before asking
- [X] I had searched in the [feature](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22) and found no similar feature requirement.
### Description
### Hello everyone, when I looked at the source code related to cdc, I found that there are some things that seem to be improved
#### Question 1
- When constructing MySql, SqlServer, and SourceConfig, some repeated string keys appear directly in the code
- Is it possible to extract these same operations involved in building Properties into public methods, each class only needs to handle different content separately?
- Make other JdbcSourceConfigFactory subclass factory code simpler and more elegant.
- Below is the existing code
- mysql
- sqlServer
#### Question 2
- The JdbcSourceOptions class in the connector-cdc-base module is a public options class, and the PORT field attribute defaults to 3306. This port is only used by mysql, and other databases may have some hidden dangers when using this key.
#### Question 3
- I found that there may be inelegant writing in the code of some options
- For example
---
#### Remarks
- I have carefully read the source code of flink, and some excellent codes related to options and configuration of flink can simplify integration into the seatunnel project.
- Hope to join this project and submit an issue for the first time. Hope my suggestion can make the seatunnel part code more elegant.
- If my suggestion is effective, please assign me this task。
- Can you leave valuable suggestions on this issue, which will enable me to integrate into the seatunel project more quickly。Tasnks [How to join this project](https://github.com/apache/incubator-seatunnel/discussions/397)
### Usage Scenario
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] 2000liux closed issue #3971: [Feature][connector-cdc] Configuration-related optimization suggestions
Posted by "2000liux (via GitHub)" <gi...@apache.org>.
2000liux closed issue #3971: [Feature][connector-cdc] Configuration-related optimization suggestions
URL: https://github.com/apache/incubator-seatunnel/issues/3971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] 2000liux commented on issue #3971: [Feature][connector-cdc] Configuration-related optimization suggestions
Posted by GitBox <gi...@apache.org>.
2000liux commented on issue #3971:
URL: https://github.com/apache/incubator-seatunnel/issues/3971#issuecomment-1385428027
Is my issue tag correct ？
- 我的这个 issue 标签是否正确？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on issue #3971: [Feature][connector-cdc] Configuration-related optimization suggestions
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on issue #3971:
URL: https://github.com/apache/incubator-seatunnel/issues/3971#issuecomment-1386423351
> @TyrantLucifer Is there a development group. I may encounter some problems in the development process and hope to solve them。
>
> * For example, properties in the base class are inaccessible. Its access right is protected
> * 
> * for example:
>
> * Can I build a map or pojo at the end of the fromReadonlyConfig method and provide the map public get method so that these properties can be accessed in the provided construction Properties public class, or have better suggestions.
You can add my wechat: tyrantlucifer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on issue #3971: [Feature][connector-cdc] Configuration-related optimization suggestions
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on issue #3971:
URL: https://github.com/apache/incubator-seatunnel/issues/3971#issuecomment-1386408325
Looking forward your contirbution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] 2000liux commented on issue #3971: [Feature][connector-cdc] Configuration-related optimization suggestions
Posted by GitBox <gi...@apache.org>.
2000liux commented on issue #3971:
URL: https://github.com/apache/incubator-seatunnel/issues/3971#issuecomment-1386420824
@TyrantLucifer
Is there a development group. I may encounter some problems in the development process and hope to solve them。
- For example, properties in the base class are inaccessible. Its access right is protected
- 
- for example:
- Can I build a map or pojo at the end of the fromReadonlyConfig method and provide the map public get method so that these properties can be accessed in the provided construction Properties public class, or have better suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org