You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/08 23:29:23 UTC
[kudu-CR] webserver: port fix for IMPALA-9001 to Kudu
Hello Thomas Tauber-Marshall, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14393
to review the following change.
Change subject: webserver: port fix for IMPALA-9001 to Kudu
......................................................................
webserver: port fix for IMPALA-9001 to Kudu
It's not a straight cherry-pick because the Impala fix includes a change to
Thrift authn, and because Kudu can leverage EasyCurl to test the change.
Change-Id: I9231677beb5990772736cf349c88f4b2b3344a7c
---
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
2 files changed, 22 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/14393/1
--
To view, visit http://gerrit.cloudera.org:8080/14393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9231677beb5990772736cf349c88f4b2b3344a7c
Gerrit-Change-Number: 14393
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[kudu-CR] webserver: port fix for IMPALA-9001 to Kudu
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14393 )
Change subject: webserver: port fix for IMPALA-9001 to Kudu
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9231677beb5990772736cf349c88f4b2b3344a7c
Gerrit-Change-Number: 14393
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Oct 2019 00:23:23 +0000
Gerrit-HasComments: No
[kudu-CR] webserver: port fix for IMPALA-9001 to Kudu
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14393 )
Change subject: webserver: port fix for IMPALA-9001 to Kudu
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14393/1/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:
http://gerrit.cloudera.org:8080/#/c/14393/1/src/kudu/server/webserver.cc@143
PS1, Line 143: If authentication fails or the header
: // is invalid, a bad Status will be returned (and the other out-parameters left untouched).
> Could you update this in-line doc to reflect the fix?
Done
http://gerrit.cloudera.org:8080/#/c/14393/1/src/kudu/server/webserver.cc@148
PS1, Line 148: static const char* kNegotiateStr
> nit: static const char* const kNegotiateStr ?
Done
--
To view, visit http://gerrit.cloudera.org:8080/14393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9231677beb5990772736cf349c88f4b2b3344a7c
Gerrit-Change-Number: 14393
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Oct 2019 04:24:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] webserver: port fix for IMPALA-9001 to Kudu
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14393 )
Change subject: webserver: port fix for IMPALA-9001 to Kudu
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9231677beb5990772736cf349c88f4b2b3344a7c
Gerrit-Change-Number: 14393
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Oct 2019 05:58:17 +0000
Gerrit-HasComments: No
[kudu-CR] webserver: port fix for IMPALA-9001 to Kudu
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14393 )
Change subject: webserver: port fix for IMPALA-9001 to Kudu
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14393/1/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:
http://gerrit.cloudera.org:8080/#/c/14393/1/src/kudu/server/webserver.cc@143
PS1, Line 143: If authentication fails or the header
: // is invalid, a bad Status will be returned (and the other out-parameters left untouched).
Could you update this in-line doc to reflect the fix?
http://gerrit.cloudera.org:8080/#/c/14393/1/src/kudu/server/webserver.cc@148
PS1, Line 148: static const char* kNegotiateStr
nit: static const char* const kNegotiateStr ?
--
To view, visit http://gerrit.cloudera.org:8080/14393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9231677beb5990772736cf349c88f4b2b3344a7c
Gerrit-Change-Number: 14393
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Oct 2019 01:38:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] webserver: port fix for IMPALA-9001 to Kudu
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14393 )
Change subject: webserver: port fix for IMPALA-9001 to Kudu
......................................................................
webserver: port fix for IMPALA-9001 to Kudu
It's not a straight cherry-pick because the Impala fix includes a change to
Thrift authn, and because Kudu can leverage EasyCurl to test the change.
Change-Id: I9231677beb5990772736cf349c88f4b2b3344a7c
Reviewed-on: http://gerrit.cloudera.org:8080/14393
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
2 files changed, 28 insertions(+), 6 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9231677beb5990772736cf349c88f4b2b3344a7c
Gerrit-Change-Number: 14393
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[kudu-CR] webserver: port fix for IMPALA-9001 to Kudu
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14393
to look at the new patch set (#2).
Change subject: webserver: port fix for IMPALA-9001 to Kudu
......................................................................
webserver: port fix for IMPALA-9001 to Kudu
It's not a straight cherry-pick because the Impala fix includes a change to
Thrift authn, and because Kudu can leverage EasyCurl to test the change.
Change-Id: I9231677beb5990772736cf349c88f4b2b3344a7c
---
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
2 files changed, 28 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/14393/2
--
To view, visit http://gerrit.cloudera.org:8080/14393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9231677beb5990772736cf349c88f4b2b3344a7c
Gerrit-Change-Number: 14393
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>