You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by ghajos <gi...@git.apache.org> on 2018/04/23 13:26:04 UTC
[GitHub] storm pull request #2643: STORM-3039 handle slot ports in TIME_WAIT state
GitHub user ghajos opened a pull request:
https://github.com/apache/storm/pull/2643
STORM-3039 handle slot ports in TIME_WAIT state
When worker is killed slot port remains in TIME_WAIT state. Since worker process is killed it is secure to start a new worker process on the same port.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ghajos/storm STORM-3039
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2643.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2643
----
commit a8978ab3543e00cf4e94ae361d4d1935b44b69f2
Author: Gergely Hajos <ro...@...>
Date: 2018-04-23T12:31:14Z
STORM-3039 handle slot ports in TIME_WAIT state
----
---
[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2643
I don't feel it is mandatory to add a test since it is a known option. I'll merge this shortly since no one add new review comments so far.
@raghavgautam Could you please submit a patch on top of this if you have some ideas to test the option? Thanks in advance.
---
[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state
Posted by raghavgautam <gi...@git.apache.org>.
Github user raghavgautam commented on the issue:
https://github.com/apache/storm/pull/2643
Can you please add a test for this ?
---
[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2643
Anyway +1 again.
---
[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state
Posted by raghavgautam <gi...@git.apache.org>.
Github user raghavgautam commented on the issue:
https://github.com/apache/storm/pull/2643
👍
---
[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state
Posted by ghajos <gi...@git.apache.org>.
Github user ghajos commented on the issue:
https://github.com/apache/storm/pull/2643
@raghavgautam I think it is out of scope to test a tcp testing in Storm. Do you have an idea how to do that?
---
[GitHub] storm pull request #2643: STORM-3039 handle slot ports in TIME_WAIT state
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2643
---
[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2643
+1
---
[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state
Posted by raghavgautam <gi...@git.apache.org>.
Github user raghavgautam commented on the issue:
https://github.com/apache/storm/pull/2643
@HeartSaVioR Please look at this pull request https://github.com/apache/storm/pull/2660
---
[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state
Posted by ghajos <gi...@git.apache.org>.
Github user ghajos commented on the issue:
https://github.com/apache/storm/pull/2643
@HeartSaVioR @raghavgautam @arunmahadevan Thank you for the review!
---
[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state
Posted by ghajos <gi...@git.apache.org>.
Github user ghajos commented on the issue:
https://github.com/apache/storm/pull/2643
@HeartSaVioR Can you please take a look at?
---
[GitHub] storm issue #2643: STORM-3039 handle slot ports in TIME_WAIT state
Posted by raghavgautam <gi...@git.apache.org>.
Github user raghavgautam commented on the issue:
https://github.com/apache/storm/pull/2643
@ghajos We can bind to the port then close the port and then bind to the same port again. We have unit tests that can be used as a starting point.
https://github.com/apache/storm/blob/dd16ff2956c17707ab5637dd21a695daff7301cc/storm-core/test/clj/org/apache/storm/messaging/netty_unit_test.clj#L71
---