[GitHub] [tvm] masahi edited a comment on pull request #7425: [TIR] Add TIR While node

[GitBox <gi...@apache.org>]

masahi edited a comment on pull request #7425:
URL: https://github.com/apache/tvm/pull/7425#issuecomment-776703600


   @tqchen @junrushao1994 @vinx13 
   
   I went through passes and here is my summary:
   * `VectorizeLoop`: Need to disallow a while loop inside a vectorized loop. Without it, no errors occurs during lowering but the lowered code is incorrect. Add a test case `test_vectorize_while_fail()` to make sure we error out in such cases
   
   * `StorageAccessVisitor`: I don't understand what it does, but added a special visitor for `While` following the existing visitor for `IfThenElse`. Please check https://github.com/apache/tvm/pull/7425/commits/1e629b68b4112a01293683edc13c3e976a22a5bb
   
   * `CoProcSync` and `LiftAttrScope`: They both have special visitor for `IfThenElse`, but I don't understand them. They are only used by VTA, for now I just error out if we find `WhileNode` there. See https://github.com/apache/tvm/pull/7425/commits/a71066d49381aae62626593c8fd76e149e1e55ed and https://github.com/apache/tvm/pull/7425/commits/00c17d921005eecc07f4300df898b9107d15ea1d
   
   * `InjectVirtualThread`: I think we need some special handling for this, but I don't know what it should be. For now I just added a placeholder and call the base class visitor. See https://github.com/apache/tvm/pull/7425/commits/896b02fb8aba00c22696f92195d32454bd593454 and let me know what we should do here.
   
   * Do we need to change `MergeNest`? https://github.com/apache/tvm/blob/7340c02d0efe0f5eb5692fb9f4cc7573c5d056cb/src/tir/transforms/ir_utils.cc#L35-L59 I haven't touch it for now
   
   * Probably we don't need to change `hoist_if_then_else.cc` and `loop_partition.cc`. We can do something in `remove_no_op.cc`, but I think it is not important.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org