You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/27 22:31:19 UTC

[GitHub] [hudi] CTTY opened a new pull request, #6230: [HUDI-4478] Rename existing spark/flink modules with a concise name

CTTY opened a new pull request, #6230:
URL: https://github.com/apache/hudi/pull/6230

   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on pull request #6230: [HUDI-4478] Rename existing Spark/Flink modules concisely

Posted by GitBox <gi...@apache.org>.
yihua commented on PR #6230:
URL: https://github.com/apache/hudi/pull/6230#issuecomment-1198667005

   @CTTY Let's target this for the next release, not merging into master for 0.12.0.  wdyt?  cc @codope @xushiyan @alexeykudinkin @danny0405  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6230: [HUDI-4478] Rename existing spark/flink modules with a concise name

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6230:
URL: https://github.com/apache/hudi/pull/6230#issuecomment-1197482833

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0262c3a012e6912ceffb8186dae4d50d9e5ebeeb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10410",
       "triggerID" : "0262c3a012e6912ceffb8186dae4d50d9e5ebeeb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0262c3a012e6912ceffb8186dae4d50d9e5ebeeb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10410) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #6230: [HUDI-4478] Rename existing Spark/Flink modules concisely

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #6230:
URL: https://github.com/apache/hudi/pull/6230#issuecomment-1299669493

   @alexeykudinkin @CTTY : can you guys align on how to make progress on this patch. as of now, have marked it as WIP label. please remove once we have alignment and its ready to be reviewed again. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] CTTY commented on pull request #6230: [HUDI-4478] Rename existing spark/flink modules with a concise name

Posted by GitBox <gi...@apache.org>.
CTTY commented on PR #6230:
URL: https://github.com/apache/hudi/pull/6230#issuecomment-1197442457

   As discussed in https://github.com/apache/hudi/pull/5943 , we should have a more concise naming pattern for Spark/Flink modules


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] alexeykudinkin commented on pull request #6230: [HUDI-4478] Rename existing Spark/Flink modules concisely

Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on PR #6230:
URL: https://github.com/apache/hudi/pull/6230#issuecomment-1244728323

   @yihua we do, i see this PR contains actually some other changes besides just renaming the modules. We should follow-up on it after #6550 lands though (since it deduplicates many of the classes, meaning that we don't need to move these)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] alexeykudinkin commented on pull request #6230: [HUDI-4478] Rename existing Spark/Flink modules concisely

Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on PR #6230:
URL: https://github.com/apache/hudi/pull/6230#issuecomment-1198686421

   @CTTY can you please summarize the changes in the description?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on pull request #6230: [HUDI-4478] Rename existing Spark/Flink modules concisely

Posted by GitBox <gi...@apache.org>.
yihua commented on PR #6230:
URL: https://github.com/apache/hudi/pull/6230#issuecomment-1244716946

   @alexeykudinkin Do you think we still need part of the changes from this PR, given #6550?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6230: [HUDI-4478] Rename existing Spark/Flink modules concisely

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6230:
URL: https://github.com/apache/hudi/pull/6230#issuecomment-1198668756

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0262c3a012e6912ceffb8186dae4d50d9e5ebeeb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10410",
       "triggerID" : "0262c3a012e6912ceffb8186dae4d50d9e5ebeeb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18944f9a2bf0ae9a27fb9d93ffe5c9753638db85",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10436",
       "triggerID" : "18944f9a2bf0ae9a27fb9d93ffe5c9753638db85",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 18944f9a2bf0ae9a27fb9d93ffe5c9753638db85 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10436) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6230: [HUDI-4478] Rename existing spark/flink modules with a concise name

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6230:
URL: https://github.com/apache/hudi/pull/6230#issuecomment-1197548195

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0262c3a012e6912ceffb8186dae4d50d9e5ebeeb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10410",
       "triggerID" : "0262c3a012e6912ceffb8186dae4d50d9e5ebeeb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0262c3a012e6912ceffb8186dae4d50d9e5ebeeb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10410) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6230: [HUDI-4478] Rename existing spark/flink modules with a concise name

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6230:
URL: https://github.com/apache/hudi/pull/6230#issuecomment-1197480003

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0262c3a012e6912ceffb8186dae4d50d9e5ebeeb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0262c3a012e6912ceffb8186dae4d50d9e5ebeeb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0262c3a012e6912ceffb8186dae4d50d9e5ebeeb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6230: [HUDI-4478] Rename existing Spark/Flink modules concisely

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6230:
URL: https://github.com/apache/hudi/pull/6230#issuecomment-1198563264

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0262c3a012e6912ceffb8186dae4d50d9e5ebeeb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10410",
       "triggerID" : "0262c3a012e6912ceffb8186dae4d50d9e5ebeeb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18944f9a2bf0ae9a27fb9d93ffe5c9753638db85",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10436",
       "triggerID" : "18944f9a2bf0ae9a27fb9d93ffe5c9753638db85",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0262c3a012e6912ceffb8186dae4d50d9e5ebeeb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10410) 
   * 18944f9a2bf0ae9a27fb9d93ffe5c9753638db85 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10436) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6230: [HUDI-4478] Rename existing Spark/Flink modules concisely

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6230:
URL: https://github.com/apache/hudi/pull/6230#issuecomment-1198559782

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0262c3a012e6912ceffb8186dae4d50d9e5ebeeb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10410",
       "triggerID" : "0262c3a012e6912ceffb8186dae4d50d9e5ebeeb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "18944f9a2bf0ae9a27fb9d93ffe5c9753638db85",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "18944f9a2bf0ae9a27fb9d93ffe5c9753638db85",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0262c3a012e6912ceffb8186dae4d50d9e5ebeeb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10410) 
   * 18944f9a2bf0ae9a27fb9d93ffe5c9753638db85 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org