You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by pavan kumar kolamuri <pa...@gmail.com> on 2016/01/05 10:40:57 UTC
Review Request 41922: Rerun API does not work in some cases
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41922/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1720
https://issues.apache.org/jira/browse/FALCON-1720
Repository: falcon-git
Description
-------
Falcon rerun not working as expected in few cases
Diffs
-----
scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1425a97
webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java f053b76
webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java 1523b76
webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a
Diff: https://reviews.apache.org/r/41922/diff/
Testing
-------
Thanks,
pavan kumar kolamuri
Re: Review Request 41922: Rerun API does not work in some cases
Posted by pavan kumar kolamuri <pa...@gmail.com>.
> On Jan. 6, 2016, 2:14 a.m., Sowmya Ramesh wrote:
> > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java, line 255
> > <https://reviews.apache.org/r/41922/diff/2/?file=1181920#file1181920line255>
> >
> > Minor nit: This code can actually go in else if part of line 244. Will make it more readable. Why can't this check be done on props instead of jobprops?
Suppose user rerun the process instance with oozie.wf.rerun.skip.nodes and later he rerun's with just force option, since force option is there we are adding oozie.wf.rerun.failnodes in props and merging with jobprops, but jobprops will contain oozie.wf.rerun.skip.nodes because of previous rerun which lead to rerun failure of that instance as both props exist. Thats why it was not added in else if and checked in jobprops instead of props.
- pavan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41922/#review112994
-----------------------------------------------------------
On Jan. 5, 2016, 12:51 p.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41922/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 12:51 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1720
> https://issues.apache.org/jira/browse/FALCON-1720
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon rerun not working as expected in few cases
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1425a97
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java f053b76
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java 1523b76
> webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a
>
> Diff: https://reviews.apache.org/r/41922/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41922: Rerun API does not work in some cases
Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41922/#review112994
-----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java (line 254)
<https://reviews.apache.org/r/41922/#comment173474>
Minor nit: This code can actually go in else if part of line 244. Will make it more readable. Why can't this check be done on props instead of jobprops?
- Sowmya Ramesh
On Jan. 5, 2016, 12:51 p.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41922/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 12:51 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1720
> https://issues.apache.org/jira/browse/FALCON-1720
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon rerun not working as expected in few cases
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1425a97
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java f053b76
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java 1523b76
> webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a
>
> Diff: https://reviews.apache.org/r/41922/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41922: Rerun API does not work in some cases
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41922/#review112941
-----------------------------------------------------------
Ship it!
Ship It!
- Balu Vellanki
On Jan. 5, 2016, 12:51 p.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41922/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 12:51 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1720
> https://issues.apache.org/jira/browse/FALCON-1720
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon rerun not working as expected in few cases
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1425a97
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java f053b76
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java 1523b76
> webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a
>
> Diff: https://reviews.apache.org/r/41922/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41922: Rerun API does not work in some cases
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41922/#review113007
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Jan. 5, 2016, 12:51 p.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41922/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 12:51 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1720
> https://issues.apache.org/jira/browse/FALCON-1720
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon rerun not working as expected in few cases
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1425a97
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java f053b76
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java 1523b76
> webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a
>
> Diff: https://reviews.apache.org/r/41922/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41922: Rerun API does not work in some cases
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41922/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 12:51 p.m.)
Review request for Falcon.
Changes
-------
Addressed comments
Bugs: FALCON-1720
https://issues.apache.org/jira/browse/FALCON-1720
Repository: falcon-git
Description
-------
Falcon rerun not working as expected in few cases
Diffs (updated)
-----
scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1425a97
webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java f053b76
webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java 1523b76
webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a
Diff: https://reviews.apache.org/r/41922/diff/
Testing
-------
Thanks,
pavan kumar kolamuri
Re: Review Request 41922: Rerun API does not work in some cases
Posted by pavan kumar kolamuri <pa...@gmail.com>.
> On Jan. 5, 2016, 11:05 a.m., PRAGYA MITTAL wrote:
> > webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java, line 67
> > <https://reviews.apache.org/r/41922/diff/1/?file=1181675#file1181675line67>
> >
> > Can we consider adding more test cases for force rerun according to the scenarios defined in the jira.
I have added basic test cases , i hope all this test cases will be added as part of regression
- pavan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41922/#review112816
-----------------------------------------------------------
On Jan. 5, 2016, 9:40 a.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41922/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 9:40 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1720
> https://issues.apache.org/jira/browse/FALCON-1720
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon rerun not working as expected in few cases
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1425a97
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java f053b76
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java 1523b76
> webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a
>
> Diff: https://reviews.apache.org/r/41922/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41922: Rerun API does not work in some cases
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41922/#review112816
-----------------------------------------------------------
webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java (line 67)
<https://reviews.apache.org/r/41922/#comment173307>
Can we consider adding more test cases for force rerun according to the scenarios defined in the jira.
- PRAGYA MITTAL
On Jan. 5, 2016, 9:40 a.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41922/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 9:40 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1720
> https://issues.apache.org/jira/browse/FALCON-1720
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon rerun not working as expected in few cases
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1425a97
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java f053b76
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java 1523b76
> webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a
>
> Diff: https://reviews.apache.org/r/41922/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41922: Rerun API does not work in some cases
Posted by pavan kumar kolamuri <pa...@gmail.com>.
> On Jan. 5, 2016, 11:13 a.m., PRAGYA MITTAL wrote:
> > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java, line 255
> > <https://reviews.apache.org/r/41922/diff/1/?file=1181673#file1181673line255>
> >
> > Add a comment to describe this.
Will add
- pavan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41922/#review112820
-----------------------------------------------------------
On Jan. 5, 2016, 9:40 a.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41922/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 9:40 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1720
> https://issues.apache.org/jira/browse/FALCON-1720
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon rerun not working as expected in few cases
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1425a97
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java f053b76
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java 1523b76
> webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a
>
> Diff: https://reviews.apache.org/r/41922/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41922: Rerun API does not work in some cases
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41922/#review112820
-----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java (line 254)
<https://reviews.apache.org/r/41922/#comment173311>
Add a comment to describe this.
- PRAGYA MITTAL
On Jan. 5, 2016, 9:40 a.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41922/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 9:40 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1720
> https://issues.apache.org/jira/browse/FALCON-1720
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon rerun not working as expected in few cases
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1425a97
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java f053b76
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java 1523b76
> webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a
>
> Diff: https://reviews.apache.org/r/41922/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41922: Rerun API does not work in some cases
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41922/#review112811
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Jan. 5, 2016, 9:40 a.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41922/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 9:40 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1720
> https://issues.apache.org/jira/browse/FALCON-1720
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Falcon rerun not working as expected in few cases
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1425a97
> webapp/src/test/java/org/apache/falcon/resource/AbstractSchedulerManagerJerseyIT.java f053b76
> webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java 1523b76
> webapp/src/test/resources/local-process-noinputs-template.xml aabdc6a
>
> Diff: https://reviews.apache.org/r/41922/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>