You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jvwing <gi...@git.apache.org> on 2017/01/23 05:05:39 UTC
[GitHub] nifi pull request #1437: NIFI-3382 New test keystore, truststore
GitHub user jvwing opened a pull request:
https://github.com/apache/nifi/pull/1437
NIFI-3382 New test keystore, truststore
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
---
I generated new keystore `localhost-ks.jks` and truststore `localhost-ts.jks` to match the previous ones through the following incantation:
```
keytool -genkeypair -alias localhost -keyalg RSA -storepass localtest -keypass localtest -keystore localhost-ks.jks -dname "CN=localhost, OU=Apache NiFi, O=Apache, L=Santa Monica, ST=CA, C=US" -startdate "2017/01/05" -validity 10000 -noprompt
keytool -genkeypair -alias mykey -keyalg DSA -storepass localtest -keypass localtest -keystore localhost-ks.jks -dname "CN=localhost, OU=Testing, O=Research, L=Metropolis, ST=New York, C=US" -startdate "2017/01/05" -validity 10000 -noprompt
keytool -exportcert -rfc -alias localhost -keystore localhost-ks.jks -storepass localtest -file localhost_cert.pem
keytool -importcert -v -trustcacerts -alias localhost -file localhost_cert.pem -keystore localhost-ts.jks -storepass localtest -noprompt
keytool -exportcert -rfc -alias mykey -keystore localhost-ks.jks -storepass localtest -file mykey_cert.pem
keytool -importcert -v -trustcacerts -alias mykey -file mykey_cert.pem -keystore localhost-ts.jks -storepass localtest -noprompt
```
They seem to make the 0.x unit tests and master integration tests happy.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jvwing/nifi NIFI-3382-web-api-test-certs-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1437.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1437
----
commit 254c0fd45f75b211eaf997186b2cdb6931f99aac
Author: James Wing <jv...@gmail.com>
Date: 2017-01-23T04:36:25Z
NIFI-3382 New test keystore, truststore
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1437: NIFI-3382 New test keystore, truststore
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1437
I'm sorry I didn't find that earlier, @mcgilman. I would still like to fix this for the 0.x branch. I'll close this PR and open a new PR that is focused only on the certs for 0.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1437: NIFI-3382 New test keystore, truststore
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1437
No worries. Sounds like a plan. I could have opened a new JIRA but decided to just address in that PR since I was updating the integration tests. Thanks for opening the 0.x PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1437: NIFI-3382 New test keystore, truststore
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1437
The proposed 0.x change is in PR #1439.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1437: NIFI-3382 New test keystore, truststore
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing closed the pull request at:
https://github.com/apache/nifi/pull/1437
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1437: NIFI-3382 New test keystore, truststore
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1437
Hey @jvwing. I actually updated these in a separate PR that's been awaiting review for awhile now. Specifically, they were regenerated in #1399.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---