You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Aleksandar Pejakovic <a....@levi9.com> on 2015/09/18 13:59:21 UTC
Review Request 38485: SAMZA-683 add meter and histogram support in the
metrics reporter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38485/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
Fixed patch: https://reviews.apache.org/r/35053/
In Meter getMeanRate return numberOfChanges / upTime. We don't have support for oneMinuteRate, fiveMinuteRate nor fifteenMinuteRate - for that we would need to import dropwizards EWMA class. If it's ok to import it will do so.
Diffs
-----
samza-api/src/main/java/org/apache/samza/metrics/Histogram.java PRE-CREATION
samza-api/src/main/java/org/apache/samza/metrics/Meter.java PRE-CREATION
samza-api/src/main/java/org/apache/samza/metrics/MetricsRegistry.java 5a00d01
samza-api/src/main/java/org/apache/samza/metrics/MetricsVisitor.java 75abfe7
samza-api/src/main/java/org/apache/samza/metrics/ReadableMetricsRegistryListener.java 739d68f
samza-api/src/main/java/org/apache/samza/util/NoOpMetricsRegistry.java 3df855c
samza-core/src/main/scala/org/apache/samza/metrics/MetricsRegistryMap.scala 40ffee2
samza-core/src/main/scala/org/apache/samza/metrics/reporter/JmxReporter.scala e966102
samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala fb438a4
samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala 09f4dc3
Diff: https://reviews.apache.org/r/38485/diff/
Testing
-------
Thanks,
Aleksandar Pejakovic
Re: Review Request 38485: SAMZA-683 add meter and histogram support
in the metrics reporter
Posted by Aleksandar Pejakovic <a....@levi9.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38485/
-----------------------------------------------------------
(Updated Sept. 22, 2015, 8:47 a.m.)
Review request for samza.
Changes
-------
Minor changes. Added doc about Histogram and Meter to metrics.md, need to generate new java-doc and update site.
Repository: samza
Description
-------
Fixed patch: https://reviews.apache.org/r/35053/
In Meter getMeanRate return numberOfChanges / upTime. We don't have support for oneMinuteRate, fiveMinuteRate nor fifteenMinuteRate - for that we would need to import dropwizards EWMA class. If it's ok to import it will do so.
Diffs (updated)
-----
docs/learn/documentation/versioned/container/metrics.md 11a62f9
samza-api/src/main/java/org/apache/samza/metrics/Histogram.java PRE-CREATION
samza-api/src/main/java/org/apache/samza/metrics/Meter.java PRE-CREATION
samza-api/src/main/java/org/apache/samza/metrics/MetricsRegistry.java 5a00d01
samza-api/src/main/java/org/apache/samza/metrics/MetricsVisitor.java 75abfe7
samza-api/src/main/java/org/apache/samza/metrics/ReadableMetricsRegistryListener.java 739d68f
samza-api/src/main/java/org/apache/samza/util/NoOpMetricsRegistry.java 3df855c
samza-core/src/main/scala/org/apache/samza/metrics/MetricsRegistryMap.scala 40ffee2
samza-core/src/main/scala/org/apache/samza/metrics/reporter/JmxReporter.scala e966102
samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala fb438a4
samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala 09f4dc3
Diff: https://reviews.apache.org/r/38485/diff/
Testing
-------
Thanks,
Aleksandar Pejakovic