You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/20 17:22:46 UTC
[GitHub] [arrow] zeroshade opened a new pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment
zeroshade opened a new pull request #12214:
URL: https://github.com/apache/arrow/pull/12214
The `//go:build` syntax being used in place of `// +build` was introduced in go1.17. Our CI runs with go1.16 so as long as we want to support go1.16 we need both the `//go:build` and `// +build` . Currently only the `cpu_arm64.go` file has the `//go:build` syntax which is only considered when building on an arm64 machine. That's why it only failed on the Apple M1 verification.
Adding the `// +build arm64` line will allow it to pass verification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12214:
URL: https://github.com/apache/arrow/pull/12214#issuecomment-1018269017
Benchmark runs are scheduled for baseline = 658bec37aa5cbdd53b5e4cdc81b8ba3962e67f11 and contender = a2fe24fe970bce082782225c16ff7ac45989884b. a2fe24fe970bce082782225c16ff7ac45989884b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/28e576650b9645fdb724548232d4357d...a4dcc5f367f04cb7b194d55688add4a4/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ac5f30256ae84501a37df1bdac42ba8b...8bf5767b00f84c869837e8de00b0fe43/)
[Finished :arrow_down:0.13% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d4669296c34c4882b5fef1cb8a3c24d9...c2a2364abc604cfcbba73a03f0150119/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #12214:
URL: https://github.com/apache/arrow/pull/12214#issuecomment-1017933010
@zeroshade the 1.16 builds are failing, could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12214:
URL: https://github.com/apache/arrow/pull/12214#issuecomment-1017785574
https://issues.apache.org/jira/browse/ARROW-15376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #12214:
URL: https://github.com/apache/arrow/pull/12214#issuecomment-1018021191
@kszucs I hope it was as simple as it looked haha
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #12214:
URL: https://github.com/apache/arrow/pull/12214#discussion_r789433557
##########
File path: .travis.yml
##########
@@ -162,8 +162,6 @@ jobs:
"
allow_failures:
- - name: "Go on ARM"
- - name: "Go on s390x"
Review comment:
Depending on the build's stability we may need to allow failures for s390x again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12214:
URL: https://github.com/apache/arrow/pull/12214#issuecomment-1018269017
Benchmark runs are scheduled for baseline = 658bec37aa5cbdd53b5e4cdc81b8ba3962e67f11 and contender = a2fe24fe970bce082782225c16ff7ac45989884b. a2fe24fe970bce082782225c16ff7ac45989884b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/28e576650b9645fdb724548232d4357d...a4dcc5f367f04cb7b194d55688add4a4/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ac5f30256ae84501a37df1bdac42ba8b...8bf5767b00f84c869837e8de00b0fe43/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d4669296c34c4882b5fef1cb8a3c24d9...c2a2364abc604cfcbba73a03f0150119/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12214:
URL: https://github.com/apache/arrow/pull/12214#issuecomment-1018269017
Benchmark runs are scheduled for baseline = 658bec37aa5cbdd53b5e4cdc81b8ba3962e67f11 and contender = a2fe24fe970bce082782225c16ff7ac45989884b. a2fe24fe970bce082782225c16ff7ac45989884b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/28e576650b9645fdb724548232d4357d...a4dcc5f367f04cb7b194d55688add4a4/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ac5f30256ae84501a37df1bdac42ba8b...8bf5767b00f84c869837e8de00b0fe43/)
[Finished :arrow_down:0.13% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d4669296c34c4882b5fef1cb8a3c24d9...c2a2364abc604cfcbba73a03f0150119/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #12214:
URL: https://github.com/apache/arrow/pull/12214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #12214:
URL: https://github.com/apache/arrow/pull/12214#issuecomment-1018019567
Go seems to be pretty sensitive to comments :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #12214:
URL: https://github.com/apache/arrow/pull/12214#issuecomment-1018020073
Could you please update the travis config so we don't allow failures anymore for go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12214: ARROW-15376: [Go][Release] cpu_arm64 needs +build comment
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12214:
URL: https://github.com/apache/arrow/pull/12214#issuecomment-1018269017
Benchmark runs are scheduled for baseline = 658bec37aa5cbdd53b5e4cdc81b8ba3962e67f11 and contender = a2fe24fe970bce082782225c16ff7ac45989884b. a2fe24fe970bce082782225c16ff7ac45989884b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/28e576650b9645fdb724548232d4357d...a4dcc5f367f04cb7b194d55688add4a4/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ac5f30256ae84501a37df1bdac42ba8b...8bf5767b00f84c869837e8de00b0fe43/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d4669296c34c4882b5fef1cb8a3c24d9...c2a2364abc604cfcbba73a03f0150119/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org