You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Kan Zhang (JIRA)" <ji...@apache.org> on 2010/09/03 01:06:33 UTC
[jira] Created: (HADOOP-6938) ConnectiionId.getConnectionId()
should check if security is enabled
ConnectiionId.getConnectionId() should check if security is enabled
-------------------------------------------------------------------
Key: HADOOP-6938
URL: https://issues.apache.org/jira/browse/HADOOP-6938
Project: Hadoop Common
Issue Type: Bug
Reporter: Kan Zhang
Assignee: Kan Zhang
When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6938) ConnectionId.getRemotePrincipal()
should check if security is enabled
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906240#action_12906240 ]
Hudson commented on HADOOP-6938:
--------------------------------
Integrated in Hadoop-Common-trunk #443 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/443/])
HADOOP-6938. ConnectionId.getRemotePrincipal() should check if security is enabled. Contributed by Kan Zhang.
> ConnectionId.getRemotePrincipal() should check if security is enabled
> ---------------------------------------------------------------------
>
> Key: HADOOP-6938
> URL: https://issues.apache.org/jira/browse/HADOOP-6938
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc, security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Fix For: 0.22.0
>
> Attachments: c6938-01.patch, c6938-03.patch, c6938-04.patch
>
>
> When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6938) ConnectionId.getRemotePrincipal()
should check if security is enabled
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905957#action_12905957 ]
Hadoop QA commented on HADOOP-6938:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12453742/c6938-03.patch
against trunk revision 991821.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system tests framework. The patch passed system tests framework compile.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/console
This message is automatically generated.
> ConnectionId.getRemotePrincipal() should check if security is enabled
> ---------------------------------------------------------------------
>
> Key: HADOOP-6938
> URL: https://issues.apache.org/jira/browse/HADOOP-6938
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc, security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c6938-01.patch, c6938-03.patch
>
>
> When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6938) ConnectionId.getRemotePrincipal()
should check if security is enabled
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906123#action_12906123 ]
Hudson commented on HADOOP-6938:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #373 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/373/])
HADOOP-6938. ConnectionId.getRemotePrincipal() should check if security is enabled. Contributed by Kan Zhang.
> ConnectionId.getRemotePrincipal() should check if security is enabled
> ---------------------------------------------------------------------
>
> Key: HADOOP-6938
> URL: https://issues.apache.org/jira/browse/HADOOP-6938
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc, security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Fix For: 0.22.0
>
> Attachments: c6938-01.patch, c6938-03.patch, c6938-04.patch
>
>
> When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6938) ConnectionId.getRemotePrincipal()
should check if security is enabled
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905985#action_12905985 ]
Kan Zhang commented on HADOOP-6938:
-----------------------------------
ran ant test and test-patch locally. All passed. Javadoc warnings are unrelated. Also ran previously-failed TestMRCLI tests with the patch, they passed as well.
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system tests framework. The patch passed system tests framework compile.
> ConnectionId.getRemotePrincipal() should check if security is enabled
> ---------------------------------------------------------------------
>
> Key: HADOOP-6938
> URL: https://issues.apache.org/jira/browse/HADOOP-6938
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc, security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c6938-01.patch, c6938-03.patch, c6938-04.patch
>
>
> When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6938) ConnectionId.getRemotePrincipal()
should check if security is enabled
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-6938:
------------------------------
Attachment: c6938-04.patch
uploading a new patch that ignores pingInterval when doPing is set to false.
> ConnectionId.getRemotePrincipal() should check if security is enabled
> ---------------------------------------------------------------------
>
> Key: HADOOP-6938
> URL: https://issues.apache.org/jira/browse/HADOOP-6938
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc, security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c6938-01.patch, c6938-03.patch, c6938-04.patch
>
>
> When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6938) ConnectiionId.getConnectionId()
should check if security is enabled
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-6938:
------------------------------
Attachment: c6938-03.patch
adding a unit test for it.
> ConnectiionId.getConnectionId() should check if security is enabled
> -------------------------------------------------------------------
>
> Key: HADOOP-6938
> URL: https://issues.apache.org/jira/browse/HADOOP-6938
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc, security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c6938-01.patch, c6938-03.patch
>
>
> When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6938) ConnectionId.getRemotePrincipal()
should check if security is enabled
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-6938:
------------------------------
Status: Patch Available (was: Open)
> ConnectionId.getRemotePrincipal() should check if security is enabled
> ---------------------------------------------------------------------
>
> Key: HADOOP-6938
> URL: https://issues.apache.org/jira/browse/HADOOP-6938
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc, security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c6938-01.patch, c6938-03.patch
>
>
> When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6938) ConnectiionId.getConnectionId()
should check if security is enabled
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-6938:
------------------------------
Component/s: ipc
security
> ConnectiionId.getConnectionId() should check if security is enabled
> -------------------------------------------------------------------
>
> Key: HADOOP-6938
> URL: https://issues.apache.org/jira/browse/HADOOP-6938
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc, security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
>
> When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6938) ConnectionId.getRemotePrincipal()
should check if security is enabled
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905979#action_12905979 ]
Hairong Kuang commented on HADOOP-6938:
---------------------------------------
+1 good catch!
> ConnectionId.getRemotePrincipal() should check if security is enabled
> ---------------------------------------------------------------------
>
> Key: HADOOP-6938
> URL: https://issues.apache.org/jira/browse/HADOOP-6938
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc, security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c6938-01.patch, c6938-03.patch, c6938-04.patch
>
>
> When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6938) ConnectionId.getRemotePrincipal()
should check if security is enabled
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-6938:
------------------------------
Summary: ConnectionId.getRemotePrincipal() should check if security is enabled (was: ConnectiionId.getConnectionId() should check if security is enabled)
> ConnectionId.getRemotePrincipal() should check if security is enabled
> ---------------------------------------------------------------------
>
> Key: HADOOP-6938
> URL: https://issues.apache.org/jira/browse/HADOOP-6938
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc, security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c6938-01.patch, c6938-03.patch
>
>
> When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6938) ConnectionId.getRemotePrincipal()
should check if security is enabled
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905961#action_12905961 ]
Kan Zhang commented on HADOOP-6938:
-----------------------------------
Similarly, I think pingInterval field should be ignored when doPing is set to false. I'll upload a new patch shortly.
> ConnectionId.getRemotePrincipal() should check if security is enabled
> ---------------------------------------------------------------------
>
> Key: HADOOP-6938
> URL: https://issues.apache.org/jira/browse/HADOOP-6938
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc, security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c6938-01.patch, c6938-03.patch
>
>
> When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6938) ConnectionId.getRemotePrincipal()
should check if security is enabled
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-6938:
----------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Fix Version/s: 0.22.0
Resolution: Fixed
I've just committed this!
> ConnectionId.getRemotePrincipal() should check if security is enabled
> ---------------------------------------------------------------------
>
> Key: HADOOP-6938
> URL: https://issues.apache.org/jira/browse/HADOOP-6938
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc, security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Fix For: 0.22.0
>
> Attachments: c6938-01.patch, c6938-03.patch, c6938-04.patch
>
>
> When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6938) ConnectiionId.getConnectionId()
should check if security is enabled
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-6938:
------------------------------
Attachment: c6938-01.patch
A one line patch.
> ConnectiionId.getConnectionId() should check if security is enabled
> -------------------------------------------------------------------
>
> Key: HADOOP-6938
> URL: https://issues.apache.org/jira/browse/HADOOP-6938
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc, security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c6938-01.patch
>
>
> When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.