You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2025/08/01 12:13:23 UTC
[PR] Merge service common [polaris]
adutra opened a new pull request, #2233:
URL: https://github.com/apache/polaris/pull/2233
As discussed in the ML here is a PR that merges polaris-service-common into polaris-runtime-service.
99% of the changes are file moves or renamings:
- d15c8265a113358696a57c2d873bf97b008e0b33 merges modules
- 6df5c2704fca38cac77c15d13d216d4e9fa0d2dd merges packages
- 1c8e65b382942c85ad854455342ab73379fa8931 renames classes
The 3rd commit merges similar classes like `QuarkusAuthenticationConfiguration` into `AuthenticationConfiguration`, instead of keeping both.
One particular interface was problematic: `FeaturesConfiguration` and its subtype `ResolvedFeaturesConfiguration`. The merger resulted in a cyclic reference when resolving CDI beans. The same issue also happened with `BehaviorChangesConfiguration` and `ResolvedBehaviorChangesConfiguration`.
To solve both cyclic reference issues, I created the following hierarchy:
<img width="1277" height="241" alt="image" src="https://github.com/user-attachments/assets/299ec93c-a764-4b9e-8320-c1ea08f1c419" />
BTW @eric-maynard what is `BehaviorChangesConfiguration` used for? It seems unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251844836
##########
runtime/service/src/test/java/org/apache/polaris/service/exception/ExceptionMapperTest.java:
##########
@@ -48,6 +48,7 @@ public class ExceptionMapperTest {
public void testFullExceptionIsLogged(
ExceptionMapper<Exception> mapper, Exception exception, Level level) {
Logger logger = (Logger) LoggerFactory.getLogger(mapper.getClass());
+ logger.setLevel(level);
Review Comment:
This test si brittle because it assumes that the logger has tested level enabled, but this is not the case anymore.
Anyways, this test is not very Quarkus-friendly. I will refactor it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #2233:
URL: https://github.com/apache/polaris/pull/2233#issuecomment-3146447024
> The failing test does not fail to me locally: `testCreateGcpCredentialsFromStaticToken` – I am investigating.
>
> EDIT: not failing anymore 😆 🤷♂️
Failing again :-(
The error is:
```
Expecting actual: 1754133695923L to be between: [1754133696234L, 1754133697234L]
```
IOW, the token expires 311 milliseconds before the lowest bound.
I think this test is probably flaky: If a GC pause happens between the token issuance and the call to `Instant.now()`, we can have more than 500 milliseconds of difference. I will provide a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251696582
##########
runtime/service/src/test/java/org/apache/polaris/service/exception/ExceptionMapperTest.java:
##########
@@ -48,6 +48,7 @@ public class ExceptionMapperTest {
public void testFullExceptionIsLogged(
ExceptionMapper<Exception> mapper, Exception exception, Level level) {
Logger logger = (Logger) LoggerFactory.getLogger(mapper.getClass());
+ logger.setLevel(level);
Review Comment:
Yes :-( there are similarly-named inner classes in `OidcTenantConfiguration`.
##########
runtime/service/src/test/java/org/apache/polaris/service/auth/external/PrincipalAuthInfoAugmentorTest.java:
##########
@@ -32,39 +32,38 @@
import java.util.Optional;
import java.util.OptionalLong;
import java.util.Set;
-import org.apache.polaris.service.quarkus.auth.external.OidcTenantConfiguration.PrincipalMapper;
-import org.apache.polaris.service.quarkus.auth.external.OidcTenantConfiguration.PrincipalRolesMapper;
-import org.apache.polaris.service.quarkus.auth.external.PrincipalAuthInfoAugmentor.OidcPrincipalAuthInfo;
+import org.apache.polaris.service.auth.external.OidcTenantConfiguration.PrincipalMapper;
+import org.apache.polaris.service.auth.external.OidcTenantConfiguration.PrincipalRolesMapper;
+import org.apache.polaris.service.auth.external.PrincipalAuthInfoAugmentor.OidcPrincipalAuthInfo;
import org.eclipse.microprofile.jwt.JsonWebToken;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
class PrincipalAuthInfoAugmentorTest {
private PrincipalAuthInfoAugmentor augmentor;
- private org.apache.polaris.service.quarkus.auth.external.mapping.PrincipalMapper principalMapper;
- private org.apache.polaris.service.quarkus.auth.external.mapping.PrincipalRolesMapper
+ private org.apache.polaris.service.auth.external.mapping.PrincipalMapper principalMapper;
+ private org.apache.polaris.service.auth.external.mapping.PrincipalRolesMapper
Review Comment:
Yes :-( there are similarly-named inner classes in OidcTenantConfiguration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra merged PR #2233:
URL: https://github.com/apache/polaris/pull/2233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #2233:
URL: https://github.com/apache/polaris/pull/2233#issuecomment-3144571544
The failing test does not fail to me locally: `testCreateGcpCredentialsFromStaticToken` – I am investigating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #2233:
URL: https://github.com/apache/polaris/pull/2233#issuecomment-3146447186
> I did not check every single file 😅
I hope you didn't ! 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251114513
##########
runtime/service/src/main/java/org/apache/polaris/service/config/BehaviorChangesConfiguration.java:
##########
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.service.config;
+
+/**
+ * FIXME: this seems unused.
Review Comment:
Well, I added this FIXME because I'm truly puzzled by this class. @eric-maynard what is this used for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251115234
##########
runtime/service/src/main/java/org/apache/polaris/service/config/RawFeaturesConfiguration.java:
##########
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.service.config;
+
+import io.smallrye.config.ConfigMapping;
+
+@ConfigMapping(prefix = "polaris.features")
Review Comment:
See my comment: https://github.com/apache/polaris/pull/2233#discussion_r2251113794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #2233:
URL: https://github.com/apache/polaris/pull/2233#issuecomment-3155214806
Hi, since this PR is generating constant rebase conflicts with other ongoing PRs, I'm going to go ahead and merge it. I hope that's ok for everybody. 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #2233:
URL: https://github.com/apache/polaris/pull/2233#issuecomment-3146507864
FYI: the flaky test should be fixed by #2241.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251113794
##########
runtime/service/src/main/java/org/apache/polaris/service/config/RawBehaviorChangesConfiguration.java:
##########
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.service.config;
+
+import io.smallrye.config.ConfigMapping;
+
+@ConfigMapping(prefix = "polaris.behavior-changes")
Review Comment:
Because this bean is injected in `ResolvedBehaviorChangesConfiguration` which also implements BehaviorChangesConfiguration, so that would result in an infinite recursion 🤷♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251696582
##########
runtime/service/src/test/java/org/apache/polaris/service/exception/ExceptionMapperTest.java:
##########
@@ -48,6 +48,7 @@ public class ExceptionMapperTest {
public void testFullExceptionIsLogged(
ExceptionMapper<Exception> mapper, Exception exception, Level level) {
Logger logger = (Logger) LoggerFactory.getLogger(mapper.getClass());
+ logger.setLevel(level);
Review Comment:
Yes :-( there are similarly-named inner classes in `OidcTenantConfiguration`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2250723965
##########
runtime/service/src/main/java/org/apache/polaris/service/task/TaskExecutorImpl.java:
##########
@@ -36,13 +44,15 @@
import org.apache.polaris.service.events.AfterTaskAttemptedEvent;
import org.apache.polaris.service.events.BeforeTaskAttemptedEvent;
import org.apache.polaris.service.events.PolarisEventListener;
+import org.apache.polaris.service.tracing.TracingFilter;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
* Given a list of registered {@link TaskHandler}s, execute tasks asynchronously with the provided
* {@link CallContext}.
*/
+@ApplicationScoped
public class TaskExecutorImpl implements TaskExecutor {
Review Comment:
```suggestion
class TaskExecutorImpl implements TaskExecutor {
```
Probably similar for other implementations.
If it works, the constructors can be package-private as well.
##########
runtime/service/src/main/java/org/apache/polaris/service/config/RawBehaviorChangesConfiguration.java:
##########
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.service.config;
+
+import io.smallrye.config.ConfigMapping;
+
+@ConfigMapping(prefix = "polaris.behavior-changes")
Review Comment:
Why not have this on the base interface?
##########
runtime/service/src/main/java/org/apache/polaris/service/config/JacksonConfig.java:
##########
@@ -31,20 +31,19 @@
import jakarta.inject.Inject;
import jakarta.inject.Singleton;
import org.apache.iceberg.rest.RESTSerializers;
-import org.apache.polaris.service.config.Serializers;
import org.eclipse.microprofile.config.inject.ConfigProperty;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@Singleton
-public class QuarkusJacksonConfig implements ObjectMapperCustomizer {
+public class JacksonConfig implements ObjectMapperCustomizer {
Review Comment:
Nomenclature:
```suggestion
public class PolarisIcebergObjectMapperCustomizer implements ObjectMapperCustomizer {
```
... because this configures the global `ObjectMapper` specific to Iceberg + inherited Polaris specifics.
##########
runtime/service/src/main/java/org/apache/polaris/service/legacy/LegacyManagementEndpoints.java:
##########
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.polaris.service.quarkus.legacy;
+package org.apache.polaris.service.legacy;
Review Comment:
Unrelated to this PR:
I suspect we can remove this one for the next release.
##########
runtime/service/src/test/java/org/apache/polaris/service/exception/ExceptionMapperTest.java:
##########
@@ -48,6 +48,7 @@ public class ExceptionMapperTest {
public void testFullExceptionIsLogged(
ExceptionMapper<Exception> mapper, Exception exception, Level level) {
Logger logger = (Logger) LoggerFactory.getLogger(mapper.getClass());
+ logger.setLevel(level);
Review Comment:
Huh? What's the reason for adding this?
##########
runtime/service/src/main/java/org/apache/polaris/service/task/TaskExecutorImpl.java:
##########
@@ -52,18 +62,28 @@ public class TaskExecutorImpl implements TaskExecutor {
private final TaskFileIOSupplier fileIOSupplier;
private final List<TaskHandler> taskHandlers = new CopyOnWriteArrayList<>();
private final PolarisEventListener polarisEventListener;
+ private final Tracer tracer;
Review Comment:
I'd prefer to make this a
```suggestion
private final Optional<Tracer> tracer;
```
I'm a bit cautious when using otel code, been bitten hard w/ static initializers in the past, although the particular test doesn't seem to harm.
##########
runtime/service/src/main/java/org/apache/polaris/service/config/RawFeaturesConfiguration.java:
##########
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.service.config;
+
+import io.smallrye.config.ConfigMapping;
+
+@ConfigMapping(prefix = "polaris.features")
Review Comment:
Why not have this on the base interface?
##########
runtime/service/src/main/java/org/apache/polaris/service/config/BehaviorChangesConfiguration.java:
##########
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.service.config;
+
+/**
+ * FIXME: this seems unused.
Review Comment:
Maybe remove?
##########
runtime/service/src/test/java/org/apache/polaris/service/auth/external/PrincipalAuthInfoAugmentorTest.java:
##########
@@ -32,39 +32,38 @@
import java.util.Optional;
import java.util.OptionalLong;
import java.util.Set;
-import org.apache.polaris.service.quarkus.auth.external.OidcTenantConfiguration.PrincipalMapper;
-import org.apache.polaris.service.quarkus.auth.external.OidcTenantConfiguration.PrincipalRolesMapper;
-import org.apache.polaris.service.quarkus.auth.external.PrincipalAuthInfoAugmentor.OidcPrincipalAuthInfo;
+import org.apache.polaris.service.auth.external.OidcTenantConfiguration.PrincipalMapper;
+import org.apache.polaris.service.auth.external.OidcTenantConfiguration.PrincipalRolesMapper;
+import org.apache.polaris.service.auth.external.PrincipalAuthInfoAugmentor.OidcPrincipalAuthInfo;
import org.eclipse.microprofile.jwt.JsonWebToken;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
class PrincipalAuthInfoAugmentorTest {
private PrincipalAuthInfoAugmentor augmentor;
- private org.apache.polaris.service.quarkus.auth.external.mapping.PrincipalMapper principalMapper;
- private org.apache.polaris.service.quarkus.auth.external.mapping.PrincipalRolesMapper
+ private org.apache.polaris.service.auth.external.mapping.PrincipalMapper principalMapper;
+ private org.apache.polaris.service.auth.external.mapping.PrincipalRolesMapper
Review Comment:
Do we still need the fully qualified types here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251691689
##########
runtime/service/src/main/java/org/apache/polaris/service/task/TaskExecutorImpl.java:
##########
@@ -52,18 +62,28 @@ public class TaskExecutorImpl implements TaskExecutor {
private final TaskFileIOSupplier fileIOSupplier;
private final List<TaskHandler> taskHandlers = new CopyOnWriteArrayList<>();
private final PolarisEventListener polarisEventListener;
+ private final Tracer tracer;
Review Comment:
But how would I inject this, `Instance<Tracer>`? I'm not sure that's better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2251844836
##########
runtime/service/src/test/java/org/apache/polaris/service/exception/ExceptionMapperTest.java:
##########
@@ -48,6 +48,7 @@ public class ExceptionMapperTest {
public void testFullExceptionIsLogged(
ExceptionMapper<Exception> mapper, Exception exception, Level level) {
Logger logger = (Logger) LoggerFactory.getLogger(mapper.getClass());
+ logger.setLevel(level);
Review Comment:
This test is brittle because it assumes that the logger has the tested level enabled, but this is not the case anymore.
Anyways, this test is not very Quarkus-friendly. I will refactor it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #2233:
URL: https://github.com/apache/polaris/pull/2233#discussion_r2252055913
##########
runtime/service/src/main/java/org/apache/polaris/service/task/TaskExecutorImpl.java:
##########
@@ -52,18 +62,28 @@ public class TaskExecutorImpl implements TaskExecutor {
private final TaskFileIOSupplier fileIOSupplier;
private final List<TaskHandler> taskHandlers = new CopyOnWriteArrayList<>();
private final PolarisEventListener polarisEventListener;
+ private final Tracer tracer;
Review Comment:
Hm,
`Instance.select().stream().findFirst()` seems to be the only way...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org