You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2016/11/04 21:12:16 UTC
[kudu-CR] Fix broken GFlags documentation link
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4955
Change subject: Fix broken GFlags documentation link
......................................................................
Fix broken GFlags documentation link
Change-Id: Ib67847245608bfe2b8bd827c34aa27ae051d97a3
---
M docs/configuration.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/4955/1
--
To view, visit http://gerrit.cloudera.org:8080/4955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib67847245608bfe2b8bd827c34aa27ae051d97a3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
[kudu-CR] Fix broken GFlags documentation link
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Fix broken GFlags documentation link
......................................................................
Patch Set 1:
Yea, the docs as rendered on github aren't properly linked. But this looks like a good fix.
--
To view, visit http://gerrit.cloudera.org:8080/4955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib67847245608bfe2b8bd827c34aa27ae051d97a3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix broken GFlags documentation link
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Fix broken GFlags documentation link
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib67847245608bfe2b8bd827c34aa27ae051d97a3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix broken GFlags documentation link
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: Fix broken GFlags documentation link
......................................................................
Patch Set 1:
> Uploaded patch set 1.
Noticed this while going through the docs.
Maybe you already know this but, I also noticed that all the doc links from Github are broken since they link to a relative HTML page, which doesn't exist. Eg:
https://github.com/apache/kudu/blob/master/docs/quickstart.adoc
The 'Installing Kudu' and 'Configuring Kudu' links are broken from here.
Not sure if theres a way to fix this without breaking the generated docs for the website.
--
To view, visit http://gerrit.cloudera.org:8080/4955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib67847245608bfe2b8bd827c34aa27ae051d97a3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[kudu-CR] Fix broken GFlags documentation link
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix broken GFlags documentation link
......................................................................
Fix broken GFlags documentation link
Change-Id: Ib67847245608bfe2b8bd827c34aa27ae051d97a3
Reviewed-on: http://gerrit.cloudera.org:8080/4955
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M docs/configuration.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib67847245608bfe2b8bd827c34aa27ae051d97a3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>