You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/13 00:39:24 UTC

[GitHub] [spark] viirya commented on a change in pull request #34246: [SPARK-36546][SQL] Add array support to union by name

viirya commented on a change in pull request #34246:
URL: https://github.com/apache/spark/pull/34246#discussion_r727612708



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala
##########
@@ -32,13 +32,28 @@ import org.apache.spark.sql.util.SchemaUtils
  * Resolves different children of Union to a common set of columns.
  */
 object ResolveUnion extends Rule[LogicalPlan] {
+  /**
+   * Transform the array of structs to the target struct type.

Review comment:
       Can it be array of array of ... of struct?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org