You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/04/29 03:07:58 UTC

[GitHub] [servicecomb-java-chassis] m13922236379 commented on a diff in pull request #2810: [#2809]A judgment condition is added when gray rules match instances. This condition applies to scenarios where instances cannot be matched in cross-app invoking.

m13922236379 commented on code in PR #2810:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2810#discussion_r861434652


##########
governance/src/main/java/org/apache/servicecomb/router/distribute/AbstractRouterDistributor.java:
##########
@@ -146,7 +150,7 @@ public void initLatestVersion(String serviceName, List<T> list) {
     String latestVersion = null;
     for (T server : list) {
       E ms = getIns.apply(server);
-      if (getServerName.apply(ms).equals(serviceName)) {
+      if (getServerName.apply(ms).equals(serviceName) || getAlias.apply(ms).equals(serviceName)) {
         if (latestVersion == null || VersionCompareUtil

Review Comment:
   同理,那getServerName应该也不能为null吧。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org