You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by geetikagupta16 <gi...@git.apache.org> on 2018/01/10 11:15:47 UTC
[GitHub] carbondata pull request #1786: [CARBONDATA-1988] Fixed bug to remove empty p...
GitHub user geetikagupta16 opened a pull request:
https://github.com/apache/carbondata/pull/1786
[CARBONDATA-1988] Fixed bug to remove empty partition directory for drop partition command
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geetikagupta16/incubator-carbondata CARBONDATA-1988
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1786.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1786
----
commit 41263d54d69a492e77275d4c375d330430cbebc3
Author: Geetika Gupta <ge...@...>
Date: 2018-01-10T10:53:55Z
Refactored code to remove partition directory for drop partition command
----
---
[GitHub] carbondata issue #1786: [CARBONDATA-1988] Fixed bug to remove empty partitio...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1786
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2679/
---
[GitHub] carbondata issue #1786: [CARBONDATA-1988] Fixed bug to remove empty partitio...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1786
LGTM
---
[GitHub] carbondata issue #1786: [CARBONDATA-1988] Fixed bug to remove empty partitio...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1786
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3266/
---
[GitHub] carbondata pull request #1786: [CARBONDATA-1988] Fixed bug to remove empty p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1786
---
[GitHub] carbondata issue #1786: [CARBONDATA-1988] Fixed bug to remove empty partitio...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1786
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3220/
---
[GitHub] carbondata issue #1786: [CARBONDATA-1988] Fixed bug to remove empty partitio...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1786
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2815/
---
[GitHub] carbondata issue #1786: [CARBONDATA-1988] Fixed bug to remove empty partitio...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1786
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3229/
---
[GitHub] carbondata pull request #1786: [CARBONDATA-1988] Fixed bug to remove empty p...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1786#discussion_r164678778
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionTableDropTestCase.scala ---
@@ -182,6 +185,30 @@ class StandardPartitionTableDropTestCase extends QueryTest with BeforeAndAfterAl
Seq(Row(0)))
}
+ test("test dropping on partition table for int partition column") {
+ sql(
+ """
+ | CREATE TABLE partitionone1 (empname String, designation String, doj Timestamp,
+ | workgroupcategory int, workgroupcategoryname String, deptno int, deptname String,
+ | projectcode int, projectjoindate Timestamp, projectenddate Date,attendance int,
+ | utilization int,salary int)
+ | PARTITIONED BY (empno int)
+ | STORED BY 'org.apache.carbondata.format'
+ """.stripMargin)
+ sql(s"""LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE partitionone1 OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '"')""")
+ checkAnswer(
+ sql(s"""select count (*) from partitionone1"""),
+ sql(s"""select count (*) from originTable"""))
+
+ checkAnswer(
+ sql(s"""select count (*) from partitionone1 where empno=11"""),
+ sql(s"""select count (*) from originTable where empno=11"""))
+
+ sql(s"""ALTER TABLE partitionone1 DROP PARTITION(empno='11')""")
+ assert(Files.notExists(Paths.get(TestQueryExecutor.warehouse + "empno=11"), LinkOption.NOFOLLOW_LINKS))
--- End diff --
it should be inside the table , not directly inside warehose path
---
[GitHub] carbondata issue #1786: [CARBONDATA-1988] Fixed bug to remove empty partitio...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1786
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2030/
---
[GitHub] carbondata issue #1786: [CARBONDATA-1988] Fixed bug to remove empty partitio...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1786
@geetikagupta16 Please add a test case
---
[GitHub] carbondata issue #1786: [CARBONDATA-1988] Fixed bug to remove empty partitio...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1786
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3186/
---
[GitHub] carbondata issue #1786: [CARBONDATA-1988] Fixed bug to remove empty partitio...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1786
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1444/
---
[GitHub] carbondata issue #1786: [CARBONDATA-1988] Fixed bug to remove empty partitio...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1786
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1445/
---
[GitHub] carbondata issue #1786: [CARBONDATA-1988] Fixed bug to remove empty partitio...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1786
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1995/
---
[GitHub] carbondata issue #1786: [CARBONDATA-1988] Fixed bug to remove empty partitio...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1786
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2816/
---
[GitHub] carbondata issue #1786: [CARBONDATA-1988] Fixed bug to remove empty partitio...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1786
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2678/
---