You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "nvollmar (via GitHub)" <gi...@apache.org> on 2023/03/02 12:03:24 UTC
[GitHub] [incubator-pekko-management] nvollmar opened a new pull request, #35: Adapts documentation for Pekko
nvollmar opened a new pull request, #35:
URL: https://github.com/apache/incubator-pekko-management/pull/35
There are still some more references/links to Lightbend/Akka that need to be re-worked.
We're also missing some sample projects:
* https://github.com/akka/akka-sample-cluster-kubernetes-java
* https://github.com/akka/akka-sample-cluster-kubernetes-dns-java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] nvollmar merged pull request #35: Adapts documentation for Pekko
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar merged PR #35:
URL: https://github.com/apache/incubator-pekko-management/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] pjfanning commented on a diff in pull request #35: Adapts documentation for Pekko
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-management/pull/35#discussion_r1123013087
##########
docs/src/main/paradox/migration.md:
##########
@@ -3,101 +3,11 @@
## 1.0
Version requirements:
+* Pekko 1.0 later
+* Pekko HTTP 1.0 or later
-* Akka 2.5.19 or later
-* Pekko HTTP 10.1.7 or later
-
-### Source changes
-
-* `PekkoManagement` moved to package `org.apache.pekko.management.scaladsl.PekkoManagement`, if using from Java use `org.apache.pekko.management.javadsl.PekkoManagement`
-* If implementing custom ManagementRouteProvider the package changed to `org.apache.pekko.management.scaladsl.ManagementRouteProvider`/`org.apache.pekko.management.javadsl.ManagementRouteProvider`
-* `PekkoManagement.start` and `PekkoManagement.routes` may throw IllegalArgumentException instead of returning Try
-* Auth and HTTPS has changed by using overloaded methods of `PekkoManagement.start` and `PekkoManagement.routes`, see the @ref[docs for more details](akka-management.md#enabling-basic-authentication)
-
-### Configuration changes
-
-* `org.apache.pekko.management.cluster.http.healthcheck.ready-states` moved to `org.apache.pekko.management.cluster.health-check.ready-states`
-* `org.apache.pekko.management.cluster.bootstrap.form-new-cluster` renamed to `org.apache.pekko.management.cluster.bootstrap.new-cluster-enabled`
-
-#### route-providers
-
-`org.apache.pekko.management.cluster.route-providers` changed from being a list of fully qualified class names to
-a configuration object `org.apache.pekko.management.cluster.routes` with named route providers. The reason for the
-change was to be able to exclude a route provider that was included by a library (from reference.conf) by
-using `""` or `null` as the FQCN of the named entry, for example:
-
-```
-pekko.management.http.routes {
- health-checks = ""
-}
-```
-
-By default the `org.apache.pekko.management.HealthCheckRoutes` is enabled.
-
-### Apache Pekko Discovery
-
-For Pekko Management version 1.0 Service Discovery as well as the config, DNS and aggregate discovery methods
-were made core Akka module. The following steps are required when upgrading to 1.0 of Pekko Management.
-
-Remove dependencies for:
-
-@@dependency[sbt,Gradle,Maven] {
- group="com.lightbend.pekko.discovery"
- artifact="pekko-discovery"
- version="old_akka_management_version"
- group2="com.lightbend.pekko.discovery"
- artifact2="pekko-discovery-dns"
- version2="old_akka_management_version"
- group3="com.lightbend.pekko.discovery"
- artifact3="pekko-discovery-config"
- version3="old_akka_management_version"
- group4="com.lightbend.pekko.discovery"
- artifact4="pekko-discovery-aggregate"
- version4="old_akka_management_version"
-}
-
-If using Cluster Bootstrap the new dependency will be brought in automatically.
-If using Service Discovery directly add the following dependency:
-
-@@dependency[sbt,Gradle,Maven] {
- group="org.apache.pekko"
- artifact="pekko-discovery"
- version="latest_akka_version"
-}
-
-Setting the service discovery method now has to be the unqualified name e.g `kubernetes-api` rather than `pekko.discovery.kubernets-api`.
-If using a custom discovery method the configuration for the discovery method must live under `pekko.discovery`.
-
-For bootstrap it is recommended to set the service discovery method via `org.apache.pekko.management.cluster.bootstrap.contact-point-discovery.discovery-method`
-rather then overriding the global service discovery mechanism with `pekko.discovery.method`
-
-### DNS
-
-If using DNS service discovery it is no longer required to override the global Akka DNS resolver. Remove `akka.io.dns.resolver = async-dns` from your configuration
-to avoid setting the `async-dns` as the global DNS resolver as it still lacks some features. The DNS discovery mechanism now uses an isolated resolver internally
-to support SRV records.
-
-### Kubernetes
-
-Kubernetes service discovery now automatically picks up the namespace at runtime. If previously hard coded or an environment variable used this can be removed
-from configuration and the deployment.
-
-Unless used for something other than service discovery / bootstrap the following can be removed from your deployment
-
-```
-- name: NAMESPACE
- valueFrom:
- fieldRef:
- fieldPath: metadata.namespace
-```
-
-If `pod-namespace` is set remove from your configuration as it will be automatically picked up from the `/var/run/secrets/kubernetes.io/serviceaccount/namespace` file
-that is mounted to each Kubernetes container. The namespace can be overridden with `pod-namespace` if this isn't the desired behavior.
-
-### Cluster HTTP
-
-The `cluster-http` module now only exposes read only routes by default. To enable destructive operations such as downing members
-set `pekko.management.http.route-providers-read-only` to `false.
+When migrating from Akka Management it is recommended to first upgrade to Akka 2.6.20 / Akka Management 1.1.4 before switching to Pekko/Pekko Management.
+Please refer to the Akka Management migration guide.
Review Comment:
we could provide a link to the Akka guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] nvollmar commented on a diff in pull request #35: Adapts documentation for Pekko
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-management/pull/35#discussion_r1123024908
##########
docs/src/main/paradox/bootstrap/recipes.md:
##########
@@ -147,7 +147,7 @@ $ sbt shell
You can run multiple different Pekko Bootstrap-based applications in the same namespace,
alongside any other containers that belong to the same logical application.
-The resources in `kubernetes/pekko-cluster.yml` are configured to run in the `akka-bootstrap-demo-ns` namespace.
Review Comment:
The Kubernetes part seems tested well enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] pjfanning commented on pull request #35: Adapts documentation for Pekko
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #35:
URL: https://github.com/apache/incubator-pekko-management/pull/35#issuecomment-1451773438
With the 2 extra Akka repos: that code is not Business Software Licensed. If someone volunteers to produce Pekko equivalents, they could use their own non-Apache forks. Alternatively, we could create Pekko repos when a volunteer pops up.
For now, we could just document that those Akka-based samples are still useful for learning - that anything learned from them is still valid with Pekko (users just need to migrate their code to use Pekko libs instead).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] pjfanning commented on a diff in pull request #35: Adapts documentation for Pekko
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-management/pull/35#discussion_r1123009390
##########
docs/src/main/paradox/kubernetes-lease.md:
##########
@@ -7,7 +7,7 @@ The API, configuration and behavior may change based on feedback from initial us
@@@
-This module is an implementation of an [Akka Coordination Lease](https://doc.akka.io/docs/akka/current/coordination.html#lease) backed
+This module is an implementation of a [Akka Coordination Lease](https://doc.akka.io/docs/akka/current/coordination.html#lease) backed
Review Comment:
should this be Pekko Coordination Lease with a link to pekko.apache.org?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] nvollmar commented on a diff in pull request #35: Adapts documentation for Pekko
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-management/pull/35#discussion_r1123017027
##########
docs/src/main/paradox/kubernetes-lease.md:
##########
@@ -7,7 +7,7 @@ The API, configuration and behavior may change based on feedback from initial us
@@@
-This module is an implementation of an [Akka Coordination Lease](https://doc.akka.io/docs/akka/current/coordination.html#lease) backed
+This module is an implementation of a [Akka Coordination Lease](https://doc.akka.io/docs/akka/current/coordination.html#lease) backed
Review Comment:
will fix that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] pjfanning commented on a diff in pull request #35: Adapts documentation for Pekko
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko-management/pull/35#discussion_r1123020440
##########
docs/src/main/paradox/bootstrap/recipes.md:
##########
@@ -147,7 +147,7 @@ $ sbt shell
You can run multiple different Pekko Bootstrap-based applications in the same namespace,
alongside any other containers that belong to the same logical application.
-The resources in `kubernetes/pekko-cluster.yml` are configured to run in the `akka-bootstrap-demo-ns` namespace.
Review Comment:
I haven't tested #36 but I'm hoping CI build is enough to prove the new names are ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org