You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/28 07:09:36 UTC

[GitHub] ArmageddonKnight opened a new pull request #11075: [MXNET-490] Added OpenLSTMRNN together with benchmarks and Tensorboard callback routines.

ArmageddonKnight opened a new pull request #11075: [MXNET-490] Added OpenLSTMRNN together with benchmarks and Tensorboard callback routines.
URL: https://github.com/apache/incubator-mxnet/pull/11075
 
 
   ## Description ##
   This PR added an open-source LSTM RNN implementation, and also included benchmarks for comparison between different LSTM RNN backends and tools for measurements.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x] Added `OpenLSTMRNN`, an LSTM RNN CUDA implementation to the MXNet C++ core library (`./src/operator/contrib/`).
   - [x] Added `TensorboardSpeedometer` and `TensorboardLogValidationMetricsCallback` for logging training and validation scores as training progresses.
   - [x] Added benchmarks in `example` directory for comparison between MXNet default, cuDNN, and `OpenLSTMRNN` backend implementations. 
   
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services