fix for freemarker findByAnd bug

[Adam Heath <do...@brainfood.com>]

I'd like to install a custom-compiled version of freemarker, with the 
fix I have posted to this list previously.  Upstream seems amicable to 
the change, if it is made so that it doesn't break backwards 
compatibility.  The last patch I sent does so.

I know in the past we have resisted having custom-compiled versions.  In 
this case, I think we need to act a bit more quickly to fix this bug in 
ofbiz, as it's preventing trunk from being used(all the findByAnd calls 
in ftl don't work right now), and freemarker hasn't released a new 
version yet.

Re: fix for freemarker findByAnd bug

[Hans Bakker <ma...@antwebsystems.com>]

I am favor of going ahead with this, we cannot have the HEAD of the 
trunk unusable too long....

Regards,
Hans

On 05/20/2012 04:38 AM, Adam Heath wrote:
> I'd like to install a custom-compiled version of freemarker, with the 
> fix I have posted to this list previously.  Upstream seems amicable to 
> the change, if it is made so that it doesn't break backwards 
> compatibility.  The last patch I sent does so.
>
> I know in the past we have resisted having custom-compiled versions.  
> In this case, I think we need to act a bit more quickly to fix this 
> bug in ofbiz, as it's preventing trunk from being used(all the 
> findByAnd calls in ftl don't work right now), and freemarker hasn't 
> released a new version yet.

Re: fix for freemarker findByAnd bug

[Adam Heath <do...@brainfood.com>]

On 05/19/2012 07:47 PM, Adrian Crum wrote:
> That's fine with me. Please include in the commit log a note describing
> which forthcoming version we should replace the custom code with.

Was going to link to the upstream bug(I've already done that in the 
local git commit).  I'm guessing 2.3.20, but I don't think I get to make 
that call.

I've got to sign a CLA first, before they will accept my patch; that 
means waiting until Monday, as I have to send it snail-mail, then 
however long it takes to wander across the country.

Because of that CLA delay, I thought I should try to get it fixed 
sooner; I don't want to wait for yet another week.

Re: fix for freemarker findByAnd bug

[Adrian Crum <ad...@sandglass-software.com>]

That's fine with me. Please include in the commit log a note describing 
which forthcoming version we should replace the custom code with.

-Adrian

On 5/19/2012 10:38 PM, Adam Heath wrote:
> I'd like to install a custom-compiled version of freemarker, with the 
> fix I have posted to this list previously.  Upstream seems amicable to 
> the change, if it is made so that it doesn't break backwards 
> compatibility.  The last patch I sent does so.
>
> I know in the past we have resisted having custom-compiled versions.  
> In this case, I think we need to act a bit more quickly to fix this 
> bug in ofbiz, as it's preventing trunk from being used(all the 
> findByAnd calls in ftl don't work right now), and freemarker hasn't 
> released a new version yet.