You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Nicolas Colomer <co...@gmail.com> on 2016/09/23 14:02:45 UTC
Re: Review Request 49212: RFC: SAMZA-855: Update kafka client to
0.10.0.0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49212/#review150178
-----------------------------------------------------------
I reworked Robert Crim's patch and rebased it on current Samza master (commit [49dac97](https://github.com/apache/samza/commit/49dac97) @ 2016-09-21T18:52:54Z)
See [SAMZA-855](https://issues.apache.org/jira/browse/SAMZA-855) issue and [apache/samza#15](https://github.com/apache/samza/pull/15) PR for the details.
- Nicolas Colomer
On juin 24, 2016, 7:45 apr�s-midi, Robert Crim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49212/
> -----------------------------------------------------------
>
> (Updated juin 24, 2016, 7:45 apr�s-midi)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> This is a WIP for updating the the kafka client libraries to 0.10+. So far, I've updated the dependency and simply worked to get all existing tests passing. The next steps are to further test/verify backwards compatiblity with older brokers and moving the current `KafkaSystemFactory`, etc, to `OldKafkaSystemFactory` and implementing the new clients.
>
>
> Diffs
> -----
>
> build.gradle ba4a9d1
> gradle/dependency-versions.gradle 47c71bf
> samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala ea10cae
> samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 4e97376
> samza-kafka/src/main/scala/org/apache/samza/config/RegExTopicGenerator.scala 78467bf
> samza-kafka/src/main/scala/org/apache/samza/migration/KafkaCheckpointMigration.scala 5e8cc65
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala ba8de5c
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala b373753
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala b574176
> samza-kafka/src/main/scala/org/apache/samza/util/KafkaUtil.scala a25ba62
> samza-kafka/src/test/java/org/apache/samza/system/kafka/MockKafkaProducer.java 6f498de
> samza-kafka/src/test/java/org/apache/samza/utils/TestUtils.java 2fa743f
> samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala e6815da
> samza-kafka/src/test/scala/org/apache/samza/migration/TestKafkaCheckpointMigration.scala 504fc89
> samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala f00405d
> samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemConsumer.scala ece0359
> samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala 8e32bba
> samza-test/src/test/scala/org/apache/samza/test/integration/StreamTaskTestUtil.scala 8d7e3fe
>
> Diff: https://reviews.apache.org/r/49212/diff/
>
>
> Testing
> -------
>
> Got `./gradlew clean check` passing. I've not been able to run the integration tests (on any branch) but will do that next!
>
>
> Thanks,
>
> Robert Crim
>
>