You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2020/05/30 08:22:13 UTC

[maven-ejb-plugin] branch master updated: Fix spotbugs:DLS_DEAD_LOCAL_STORE

This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-ejb-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 33b1e45  Fix spotbugs:DLS_DEAD_LOCAL_STORE
33b1e45 is described below

commit 33b1e45e902ffb18b207129d7d3acc0217846bc4
Author: Piotrek Żygieło <pz...@users.noreply.github.com>
AuthorDate: Sun Apr 12 14:40:28 2020 +0200

    Fix spotbugs:DLS_DEAD_LOCAL_STORE
    
    https://rules.sonarsource.com/java/type/Code%20Smell/RSPEC-1854
---
 src/main/java/org/apache/maven/plugins/ejb/IncludesExcludes.java | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugins/ejb/IncludesExcludes.java b/src/main/java/org/apache/maven/plugins/ejb/IncludesExcludes.java
index 337d622..9013109 100644
--- a/src/main/java/org/apache/maven/plugins/ejb/IncludesExcludes.java
+++ b/src/main/java/org/apache/maven/plugins/ejb/IncludesExcludes.java
@@ -56,17 +56,14 @@ public class IncludesExcludes
 
     private static String[] resultingXcludes( List<String> currentXcludes, List<String> defaultXcludes )
     {
-        String[] result = new String[0];
         if ( currentXcludes.isEmpty() )
         {
-            result = defaultXcludes.toArray( new String[0] );
+            return defaultXcludes.toArray( new String[0] );
         }
         else
         {
-            result = currentXcludes.toArray( new String[0] );
+            return currentXcludes.toArray( new String[0] );
         }
-
-        return result;
     }
 
     private List<String> makeNonNullList( List<String> in )