[GitHub] [tvm] mbaret commented on a change in pull request #7754: [PatternMatcher] Support matching tuples, call nodes, and functions with variable numbers of inputs

[GitBox <gi...@apache.org>]

mbaret commented on a change in pull request #7754:
URL: https://github.com/apache/tvm/pull/7754#discussion_r604223799



##########
File path: tests/python/relay/test_dataflow_pattern.py
##########
@@ -1375,6 +1392,63 @@ def test_partition_overused():
     assert pattern.partition(out) == out
 
 
+def test_partition_fuzzy_tuple():
+    x = relay.var("x")
+    y = relay.var("y")
+    z = x + y
+    tuple_pattern = is_tuple(None)

Review comment:
       I agree the use of `None` here is a bit confusing, I think I'd naturally interpret it the other way around actually. Specifically, `None` seems like you're explicitly requesting that there be no arguments rather than an unknown number. Just as a suggestion, would a syntax like `is_tuple(args())` be clearer where we explicitly introduce a new pattern which matches a variable number of arguments?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org