You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/28 07:43:26 UTC
[GitHub] [shardingsphere] tuohai666 opened a new pull request #7120: #7011, Investigate whether missing call close
tuohai666 opened a new pull request #7120:
URL: https://github.com/apache/shardingsphere/pull/7120
Fixes #7011.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7120: #7011, Investigate whether missing call close
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7120:
URL: https://github.com/apache/shardingsphere/pull/7120#issuecomment-682420645
## Pull Request Test Coverage Report for [Build 14211](https://coveralls.io/builds/33067770)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage increased (+**0.07%**) to **35.397%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/auth/PostgreSQLAuthenticationEngine.java](https://coveralls.io/builds/33067770/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-frontend%2Fshardingsphere-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Ffrontend%2Fpostgresql%2Fauth%2FPostgreSQLAuthenticationEngine.java#L104) | 1 | 88.89% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/33067770) |
| :-- | --: |
| Change from base [Build 14207](https://coveralls.io/builds/33065258): | 0.07% |
| Covered Lines: | 35332 |
| Relevant Lines: | 99816 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #7120: #7011, Investigate whether missing call close
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #7120:
URL: https://github.com/apache/shardingsphere/pull/7120
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 commented on pull request #7120: #7011, Investigate whether missing call close
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on pull request #7120:
URL: https://github.com/apache/shardingsphere/pull/7120#issuecomment-682731192
> If there is no need to call close, do we need to keep the close method?
Not really. The life cycle of UserExecutorGroup is identical with ShardingSphere-Proxy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org