You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Karen Miller <km...@pivotal.io> on 2016/11/02 23:52:54 UTC

Review Request 53414: GEODE-2065 Document defragmentationsInProgress statistic

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53414/
-----------------------------------------------------------

Review request for geode, Dave Barnes, Darrel Schneider, and Joey McAllister.


Repository: geode


Description
-------

This is a sub-task of GEODE-1590.


Diffs
-----

  geode-docs/reference/statistics/statistics_list.html.md.erb 07e4281f239b73896ed7b1b2fbb6429c87ac5024 

Diff: https://reviews.apache.org/r/53414/diff/


Testing
-------

gradle rat check passes


Thanks,

Karen Miller


Re: Review Request 53414: GEODE-2065 Document defragmentationsInProgress statistic

Posted by Dave Barnes <db...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53414/#review154741
-----------------------------------------------------------


Ship it!




Ship It!

- Dave Barnes


On Nov. 2, 2016, 11:52 p.m., Karen Miller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53414/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 11:52 p.m.)
> 
> 
> Review request for geode, Dave Barnes, Darrel Schneider, and Joey McAllister.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This is a sub-task of GEODE-1590.
> 
> 
> Diffs
> -----
> 
>   geode-docs/reference/statistics/statistics_list.html.md.erb 07e4281f239b73896ed7b1b2fbb6429c87ac5024 
> 
> Diff: https://reviews.apache.org/r/53414/diff/
> 
> 
> Testing
> -------
> 
> gradle rat check passes
> 
> 
> Thanks,
> 
> Karen Miller
> 
>


Re: Review Request 53414: GEODE-2065 Document defragmentationsInProgress statistic

Posted by Joey McAllister <jm...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53414/#review154661
-----------------------------------------------------------


Ship it!




Ship It!

- Joey McAllister


On Nov. 2, 2016, 11:52 p.m., Karen Miller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53414/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 11:52 p.m.)
> 
> 
> Review request for geode, Dave Barnes, Darrel Schneider, and Joey McAllister.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This is a sub-task of GEODE-1590.
> 
> 
> Diffs
> -----
> 
>   geode-docs/reference/statistics/statistics_list.html.md.erb 07e4281f239b73896ed7b1b2fbb6429c87ac5024 
> 
> Diff: https://reviews.apache.org/r/53414/diff/
> 
> 
> Testing
> -------
> 
> gradle rat check passes
> 
> 
> Thanks,
> 
> Karen Miller
> 
>


Re: Review Request 53414: GEODE-2065 Document defragmentationsInProgress statistic

Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53414/#review154767
-----------------------------------------------------------


Ship it!




Ship It!

- Darrel Schneider


On Nov. 3, 2016, 10:04 a.m., Karen Miller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53414/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 10:04 a.m.)
> 
> 
> Review request for geode, Dave Barnes, Darrel Schneider, and Joey McAllister.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This is a sub-task of GEODE-1590.
> 
> 
> Diffs
> -----
> 
>   geode-docs/reference/statistics/statistics_list.html.md.erb 07e4281f239b73896ed7b1b2fbb6429c87ac5024 
> 
> Diff: https://reviews.apache.org/r/53414/diff/
> 
> 
> Testing
> -------
> 
> gradle rat check passes
> 
> 
> Thanks,
> 
> Karen Miller
> 
>


Re: Review Request 53414: GEODE-2065 Document defragmentationsInProgress statistic

Posted by Karen Miller <km...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53414/
-----------------------------------------------------------

(Updated Nov. 3, 2016, 5:04 p.m.)


Review request for geode, Dave Barnes, Darrel Schneider, and Joey McAllister.


Repository: geode


Description
-------

This is a sub-task of GEODE-1590.


Diffs (updated)
-----

  geode-docs/reference/statistics/statistics_list.html.md.erb 07e4281f239b73896ed7b1b2fbb6429c87ac5024 

Diff: https://reviews.apache.org/r/53414/diff/


Testing
-------

gradle rat check passes


Thanks,

Karen Miller


Re: Review Request 53414: GEODE-2065 Document defragmentationsInProgress statistic

Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53414/#review154761
-----------------------------------------------------------




geode-docs/reference/statistics/statistics_list.html.md.erb (line 1016)
<https://reviews.apache.org/r/53414/#comment224444>

    I would change "integer number" to "number of". Almost all of our stats are integers so I don't think you need to say that.


- Darrel Schneider


On Nov. 2, 2016, 4:52 p.m., Karen Miller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53414/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 4:52 p.m.)
> 
> 
> Review request for geode, Dave Barnes, Darrel Schneider, and Joey McAllister.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This is a sub-task of GEODE-1590.
> 
> 
> Diffs
> -----
> 
>   geode-docs/reference/statistics/statistics_list.html.md.erb 07e4281f239b73896ed7b1b2fbb6429c87ac5024 
> 
> Diff: https://reviews.apache.org/r/53414/diff/
> 
> 
> Testing
> -------
> 
> gradle rat check passes
> 
> 
> Thanks,
> 
> Karen Miller
> 
>