You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/02 14:51:50 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #757:
HDDS-3332. Make Robot test invocation independent from Python version
adoroszlai opened a new pull request #757: HDDS-3332. Make Robot test invocation independent from Python version
URL: https://github.com/apache/hadoop-ozone/pull/757
## What changes were proposed in this pull request?
Invoke `robot` directly, without referencing `python` command. This allows using Python 2 or 3 depending on which version Robot Framework was installed with. After this, we can upgrade the `ozone-runner` docker image to Python 3.
https://issues.apache.org/jira/browse/HDDS-3332
## How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/555065119
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #757: HDDS-3332. Make
Robot test invocation independent from Python version
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #757: HDDS-3332. Make Robot test invocation independent from Python version
URL: https://github.com/apache/hadoop-ozone/pull/757#issuecomment-608395938
> I would expect that `robot` uses the same python which is used to install it (eg `pip2` --> `python`). And it seems to be strange if `robot` which is installed with `pip` can be visible for a different python version.
I expect the same. I didn't mean that the same Robot installation can be used regardless of Python version (I don't know if that would work or not). This change only makes it possible to install via `pip3` without breaking the test.
> We need to update the version of the `ozone-runner` for the full fix, doesnt' we?
> If yes, would to do it here in an other PR?
Yes, we need that, too. I'd prefer a separate PR (but the same issue).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #757: HDDS-3332. Make
Robot test invocation independent from Python version
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #757: HDDS-3332. Make Robot test invocation independent from Python version
URL: https://github.com/apache/hadoop-ozone/pull/757#issuecomment-608410663
Thanks @elek for the review. I'll submit another PR for updating the runner after a clean run in my fork.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #757: HDDS-3332. Make
Robot test invocation independent from Python version
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #757: HDDS-3332. Make Robot test invocation independent from Python version
URL: https://github.com/apache/hadoop-ozone/pull/757
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #757: HDDS-3332. Make Robot
test invocation independent from Python version
Posted by GitBox <gi...@apache.org>.
elek commented on issue #757: HDDS-3332. Make Robot test invocation independent from Python version
URL: https://github.com/apache/hadoop-ozone/pull/757#issuecomment-608387908
We need to update the version of the `ozone-runner` for the full fix, doesnt' we?
If yes, would to do it here in an other PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org