[GitHub] [maven] kwin commented on a diff in pull request #862: [MNG-7588] generate reader and some beans automatically for plugin

[GitBox <gi...@apache.org>]

kwin commented on code in PR #862:
URL: https://github.com/apache/maven/pull/862#discussion_r1008809496


##########
maven-plugin-api/pom.xml:
##########
@@ -112,6 +117,53 @@ under the License.
               </params>
             </configuration>
           </execution>
+          <execution>
+            <id>velocity-plugin</id>
+            <phase>generate-sources</phase>
+            <goals>
+              <goal>velocity</goal>
+            </goals>
+            <configuration>
+              <version>1.1.0</version>
+              <models>
+                <model>src/main/mdo/plugin.mdo</model>
+              </models>
+              <templates>
+                <template>src/main/mdo/model.vm</template>
+                <template>src/main/mdo/reader.vm</template>

Review Comment:
   should we generate a writer here or rather separately in m-plugin-tools?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org