You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/09/24 13:32:42 UTC

[PR] Remove redundant project.build.sourceEncoding from IT POMs [maven-resources-plugin]

gnodet opened a new pull request, #522:
URL: https://github.com/apache/maven-resources-plugin/pull/522

   ## Summary
   
   Remove the redundant `<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>`
   property from all IT `pom.xml` files under `src/it/`.
   
   ## Rationale
   
   Since MNG-7763, Maven 4 defaults `project.build.sourceEncoding` to `UTF-8` when not
   explicitly set. Since `maven-resources-plugin` 4.x requires Maven 4, explicitly
   declaring this property in IT POMs is redundant noise. Empty `<properties>` blocks
   left after the removal are also cleaned up.
   
   ## Files changed
   
   - `src/it/MRESOURCES-110/pom.xml` — encoding line removed (block keeps `replaceThis` property)
   - `src/it/MRESOURCES-171/pom.xml` — encoding line and empty `<properties>` block removed
   - `src/it/MRESOURCES-231/pom.xml` — encoding line and empty `<properties>` block removed
   - `src/it/MRESOURCES-257/pom.xml` — encoding line and empty `<properties>` block removed
   - `src/it/gh-312/pom.xml` — encoding line removed (block keeps compiler source/target properties)
   - `src/it/include-git-ignore/pom.xml` — encoding line and empty `<properties>` block removed
   
   Note: `src/it/MRESOURCES-231/src/main/resources/test.txt` references
   `${project.build.sourceEncoding}` as a filter expression under test — it is intentionally left
   unchanged, and will still resolve correctly since Maven 4 provides the default.
   
   ---
   _Co-authored-by: Claude Sonnet 4.6 <no...@anthropic.com>_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove redundant project.build.sourceEncoding from IT POMs [maven-resources-plugin]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #522:
URL: https://github.com/apache/maven-resources-plugin/pull/522#issuecomment-5870875298

   @gnodet Please assign appropriate label to PR according to the type of change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove redundant project.build.sourceEncoding from IT POMs [maven-resources-plugin]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #522:
URL: https://github.com/apache/maven-resources-plugin/pull/522


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org