[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2663: [GOBBLIN-796] Add support partial updates for flowConfig

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #2663: [GOBBLIN-796] Add support partial updates for flowConfig
URL: https://github.com/apache/incubator-gobblin/pull/2663#discussion_r292242390
 
 

 ##########
 File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowConfigClient.java
 ##########
 @@ -121,6 +123,25 @@ public void updateFlowConfig(FlowConfig flowConfig)
     response.getResponse();
   }
 
+  /**
+   * Partially update a flow configuration
+   * @param flowId flow ID to update
+   * @param flowConfigPatch {@link PatchRequest} containing changes to the flowConfig
+   * @throws RemoteInvocationException
+   */
+  public void partialUpdateFlowConfig(FlowId flowId, PatchRequest<FlowConfig> flowConfigPatch) throws RemoteInvocationException {
 
 Review comment:
   Why is the partialUpdateFlowConfig() method duplicated in 3 different classes? Maybe move this to a Utils class?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services