You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/05/17 00:21:29 UTC

Review Request 47435: GEODE-1392: add tests for BlobHelper

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47435/
-----------------------------------------------------------

Review request for geode and Darrel Schneider.


Bugs: GEODE-1392
    https://issues.apache.org/jira/browse/GEODE-1392


Repository: geode


Description
-------

GEODE-1392: add tests for BlobHelper

* create BlobHelperTest with basic unit tests
* create BlobHelperWithThreadContextClassLoaderTest with TCCL related tests
* remove deadcode
* minor cleanup of format


Diffs
-----

  geode-core/src/main/java/com/gemstone/gemfire/internal/util/BlobHelper.java 28252c3 
  geode-core/src/test/java/com/gemstone/gemfire/internal/util/BlobHelperTest.java PRE-CREATION 
  geode-core/src/test/java/com/gemstone/gemfire/internal/util/BlobHelperWithThreadContextClassLoaderTest.java PRE-CREATION 
  geode-core/src/test/java/com/gemstone/gemfire/internal/util/SerializableImpl.java 44a8363 
  geode-core/src/test/java/com/gemstone/gemfire/internal/util/SerializableImplWithValue.java 5727ff8 
  geode-core/src/test/java/com/gemstone/gemfire/internal/util/Valuable.java f58deb9 

Diff: https://reviews.apache.org/r/47435/diff/


Testing
-------

precheckin


Thanks,

Kirk Lund