[jira] [Commented] (AIRFLOW-3741) oracle_hook add extra config

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796091#comment-16796091 ] 

ASF subversion and git services commented on AIRFLOW-3741:
----------------------------------------------------------

Commit d1442e1e025ec5dbc3a043324d3e4ba6f577d52e in airflow's branch refs/heads/v1-10-stable from zhongjiajie
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=d1442e1 ]

[AIRFLOW-3741] Add extra config to Oracle hook (#4584)

Add extra config to Oracle hook including encoding, mode, threaded etc


> oracle_hook add extra config
> ----------------------------
>
>                 Key: AIRFLOW-3741
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3741
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: hooks
>    Affects Versions: 1.10.1
>            Reporter: zhongjiajie
>            Assignee: zhongjiajie
>            Priority: Major
>              Labels: features
>             Fix For: 1.10.3
>
>
> oracle_hook get_conn block just like below
>  
> {code:java}
> if dsn and sid and not service_name:
>     dsn = cx_Oracle.makedsn(dsn, conn.port, sid)
>     conn = cx_Oracle.connect(conn.login, conn.password, dsn=dsn)
> elif dsn and service_name and not sid:
>     dsn = cx_Oracle.makedsn(dsn, conn.port, service_name=service_name)
>     conn = cx_Oracle.connect(conn.login, conn.password, dsn=dsn)
> else:
>     conn = cx_Oracle.connect(conn.login, conn.password, conn.host){code}
>  
> oracle_hook only support default encoding, not UTF-8.
> In cx_oracle [official doc|https://cx-oracle.readthedocs.io/en/latest/module.html#cx_Oracle.connect] and [github issue|https://github.com/oracle/python-cx_Oracle/issues/157] we know how to set connection encoding. I think is necessary add this feature to oracle_hook



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)