[GitHub] [iceberg] rdblue commented on a change in pull request #2367: Core: Don't delete data files on DROP if GC is disabled

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2367:
URL: https://github.com/apache/iceberg/pull/2367#discussion_r600738227



##########
File path: core/src/main/java/org/apache/iceberg/CatalogUtil.java
##########
@@ -78,7 +82,12 @@ public static void dropTableData(FileIO io, TableMetadata metadata) {
 
     // run all of the deletes
 
-    deleteFiles(io, manifestsToDelete);
+    boolean gcEnabled = PropertyUtil.propertyAsBoolean(metadata.properties(), GC_ENABLED, GC_ENABLED_DEFAULT);
+
+    if (gcEnabled) {
+      // delete data files only if GC is enabled

Review comment:
       This comment could be better to explain what the GC property is doing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org