You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Susan Hinrichs (JIRA)" <ji...@apache.org> on 2016/09/06 19:05:22 UTC

[jira] [Commented] (TS-4044) Conflict conditions in HttpSM::do_http_server_open()

    [ https://issues.apache.org/jira/browse/TS-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468240#comment-15468240 ] 

Susan Hinrichs commented on TS-4044:
------------------------------------

Yes, the POST and PUT checks make no sense.  I assume they were left over as part of a previous code re-arrangement.  TS-1883 is open to track issues about lack of timeouts in the HTTPS case (a few lines above this).  I removed the conflicting lines as part of the TS-3046 fix.  I'll follow up on the potentially missing timeouts with TS-1883.

> Conflict conditions in HttpSM::do_http_server_open()
> ----------------------------------------------------
>
>                 Key: TS-4044
>                 URL: https://issues.apache.org/jira/browse/TS-4044
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Oknet Xu
>            Assignee: Susan Hinrichs
>             Fix For: 7.0.0
>
>
> there is a conflict between the conditions of Line 4786 and 4797.  I was wondering whether it is a bug
> {code}
> 4786     if (t_state.method != HTTP_WKSIDX_CONNECT) {
> 4787       DebugSM("http", "calling netProcessor.connect_re");
> 4788       connect_action_handle = netProcessor.connect_re(this,                                 // state machine
> 4789                                                       &t_state.current.server->dst_addr.sa, // addr + port
> 4790                                                       &opt);
> 4791     } else {
> 4792       // Setup the timeouts
> 4793       // Set the inactivity timeout to the connect timeout so that we
> 4794       //   we fail this server if it doesn't start sending the response
> 4795       //   header
> 4796       MgmtInt connect_timeout;
> 4797       if (t_state.method == HTTP_WKSIDX_POST || t_state.method == HTTP_WKSIDX_PUT) {
> 4798         connect_timeout = t_state.txn_conf->post_connect_attempts_timeout;
> 4799       } else if (t_state.current.server == &t_state.parent_info) {
> 4800         connect_timeout = t_state.http_config_param->parent_connect_timeout;
> 4801       } else {
> 4802         if (t_state.pCongestionEntry != NULL)
> 4803           connect_timeout = t_state.pCongestionEntry->connect_timeout();
> 4804         else
> 4805           connect_timeout = t_state.txn_conf->connect_attempts_timeout;
> 4806       }
> 4807       DebugSM("http", "calling netProcessor.connect_s");
> 4808       connect_action_handle = netProcessor.connect_s(this,                                 // state machine
> 4809                                                      &t_state.current.server->dst_addr.sa, // addr + port
> 4810                                                      connect_timeout, &opt);
> 4811     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)