[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #3198: FINERACT-1724: Negative numbers in delinquentDays field

["josehernandezfintecheandomx (via GitHub)" <gi...@apache.org>]

josehernandezfintecheandomx commented on code in PR #3198:
URL: https://github.com/apache/fineract/pull/3198#discussion_r1203995627


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/LoanDelinquencyDomainServiceImpl.java:
##########
@@ -141,7 +141,12 @@ public CollectionData getOverdueCollectionData(final Loan loan) {
         collectionData.setDelinquentAmount(outstandingAmount);
 
         if (overdueDays > 0) {
-            collectionData.setDelinquentDays(overdueDays - graceDays);
+            Long delinquentDays = 0L;

Review Comment:
   I need to evaluate if overdue days has value, It can be null 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org