You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Wojciech Sielski <si...@gmail.com> on 2015/09/07 20:46:03 UTC
Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as
additional env variable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38165/
-----------------------------------------------------------
(Updated Sept. 7, 2015, 6:46 p.m.)
Review request for mesos.
Changes
-------
correct linking
Summary (updated)
-----------------
MESOS-3377 - Adding CONTAINER_NAME as additional env variable
Bugs: MESOS-3377
https://issues.apache.org/jira/browse/MESOS-3377
Repository: mesos
Description
-------
MOS-3377 - Adding CONTAINER_NAME as additional env variable
Diffs
-----
src/docker/docker.cpp ec2de5436ef5261a7d04eebeeded58435774cd9e
Diff: https://reviews.apache.org/r/38165/diff/
Testing
-------
Every docker container that is created by mesos,
gonna get conatiner dynamic env variable CONTAINER_NAME.
So it is easy to use by 3rd party application,
for example: when use with registartor/consul
so is it's much easier to deregister itself
(or put into maintanance mode) before being killed.
Tested and verified afetr build locally.
Thanks,
Wojciech Sielski
Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as
additional env variable
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38165/#review97942
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38165]
All tests passed.
- Mesos ReviewBot
On Sept. 7, 2015, 6:47 p.m., Wojciech Sielski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38165/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2015, 6:47 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3377
> https://issues.apache.org/jira/browse/MESOS-3377
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3377 - Adding CONTAINER_NAME as additional env variable
>
>
> Diffs
> -----
>
> src/docker/docker.cpp ec2de5436ef5261a7d04eebeeded58435774cd9e
>
> Diff: https://reviews.apache.org/r/38165/diff/
>
>
> Testing
> -------
>
> Every docker container that is created by mesos,
> gonna get conatiner dynamic env variable CONTAINER_NAME.
> So it is easy to use by 3rd party application,
> for example: when use with registartor/consul
> so is it's much easier to deregister itself
> (or put into maintanance mode) before being killed.
>
>
> Tested and verified afetr build locally.
>
>
> Thanks,
>
> Wojciech Sielski
>
>
Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as
additional env variable
Posted by Klaus Ma <kl...@cguru.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38165/#review97950
-----------------------------------------------------------
src/docker/docker.cpp (line 414)
<https://reviews.apache.org/r/38165/#comment154086>
Should we provide UT for this fix? please refer to the other test in "src/tests".
- Klaus Ma
On Sept. 7, 2015, 6:47 p.m., Wojciech Sielski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38165/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2015, 6:47 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3377
> https://issues.apache.org/jira/browse/MESOS-3377
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3377 - Adding CONTAINER_NAME as additional env variable
>
>
> Diffs
> -----
>
> src/docker/docker.cpp ec2de5436ef5261a7d04eebeeded58435774cd9e
>
> Diff: https://reviews.apache.org/r/38165/diff/
>
>
> Testing
> -------
>
> Every docker container that is created by mesos,
> gonna get conatiner dynamic env variable CONTAINER_NAME.
> So it is easy to use by 3rd party application,
> for example: when use with registartor/consul
> so is it's much easier to deregister itself
> (or put into maintanance mode) before being killed.
>
>
> Tested and verified afetr build locally.
>
>
> Thanks,
>
> Wojciech Sielski
>
>
Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as
additional env variable
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38165/#review97947
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 九月 7, 2015, 6:47 p.m., Wojciech Sielski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38165/
> -----------------------------------------------------------
>
> (Updated 九月 7, 2015, 6:47 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3377
> https://issues.apache.org/jira/browse/MESOS-3377
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3377 - Adding CONTAINER_NAME as additional env variable
>
>
> Diffs
> -----
>
> src/docker/docker.cpp ec2de5436ef5261a7d04eebeeded58435774cd9e
>
> Diff: https://reviews.apache.org/r/38165/diff/
>
>
> Testing
> -------
>
> Every docker container that is created by mesos,
> gonna get conatiner dynamic env variable CONTAINER_NAME.
> So it is easy to use by 3rd party application,
> for example: when use with registartor/consul
> so is it's much easier to deregister itself
> (or put into maintanance mode) before being killed.
>
>
> Tested and verified afetr build locally.
>
>
> Thanks,
>
> Wojciech Sielski
>
>
Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as
additional env variable
Posted by haosdent huang <ha...@gmail.com>.
> On Sept. 8, 2015, 2:57 p.m., Wojciech Sielski wrote:
> > Ship It!
Hi, @sielaq Could you add @tnachen in reviewers? Because he is the maintainer of docker container component, I think he could help decide this approach should be accepted or not. And then help you commit this if this is accepted.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38165/#review98008
-----------------------------------------------------------
On Sept. 7, 2015, 6:47 p.m., Wojciech Sielski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38165/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2015, 6:47 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3377
> https://issues.apache.org/jira/browse/MESOS-3377
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3377 - Adding CONTAINER_NAME as additional env variable
>
>
> Diffs
> -----
>
> src/docker/docker.cpp ec2de5436ef5261a7d04eebeeded58435774cd9e
>
> Diff: https://reviews.apache.org/r/38165/diff/
>
>
> Testing
> -------
>
> Every docker container that is created by mesos,
> gonna get conatiner dynamic env variable CONTAINER_NAME.
> So it is easy to use by 3rd party application,
> for example: when use with registartor/consul
> so is it's much easier to deregister itself
> (or put into maintanance mode) before being killed.
>
>
> Tested and verified afetr build locally.
>
>
> Thanks,
>
> Wojciech Sielski
>
>
Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as
additional env variable
Posted by Wojciech Sielski <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38165/#review98008
-----------------------------------------------------------
Ship it!
Ship It!
- Wojciech Sielski
On Sept. 7, 2015, 6:47 p.m., Wojciech Sielski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38165/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2015, 6:47 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3377
> https://issues.apache.org/jira/browse/MESOS-3377
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3377 - Adding CONTAINER_NAME as additional env variable
>
>
> Diffs
> -----
>
> src/docker/docker.cpp ec2de5436ef5261a7d04eebeeded58435774cd9e
>
> Diff: https://reviews.apache.org/r/38165/diff/
>
>
> Testing
> -------
>
> Every docker container that is created by mesos,
> gonna get conatiner dynamic env variable CONTAINER_NAME.
> So it is easy to use by 3rd party application,
> for example: when use with registartor/consul
> so is it's much easier to deregister itself
> (or put into maintanance mode) before being killed.
>
>
> Tested and verified afetr build locally.
>
>
> Thanks,
>
> Wojciech Sielski
>
>
Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as
additional env variable
Posted by Wojciech Sielski <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38165/
-----------------------------------------------------------
(Updated Sept. 7, 2015, 6:47 p.m.)
Review request for mesos.
Bugs: MESOS-3377
https://issues.apache.org/jira/browse/MESOS-3377
Repository: mesos
Description (updated)
-------
MESOS-3377 - Adding CONTAINER_NAME as additional env variable
Diffs
-----
src/docker/docker.cpp ec2de5436ef5261a7d04eebeeded58435774cd9e
Diff: https://reviews.apache.org/r/38165/diff/
Testing
-------
Every docker container that is created by mesos,
gonna get conatiner dynamic env variable CONTAINER_NAME.
So it is easy to use by 3rd party application,
for example: when use with registartor/consul
so is it's much easier to deregister itself
(or put into maintanance mode) before being killed.
Tested and verified afetr build locally.
Thanks,
Wojciech Sielski