You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Ruchith Fernando <ru...@gmail.com> on 2013/01/31 14:42:24 UTC

Rampart: Removing deprecated basic configuration

Hi Devs,

Is anyone opposed to removing the deprecated (since rampart-1.1) basic
configuration and just have one mode of configuration in Rampart?

Thanks,
Ruchith

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org

Re: Rampart: Removing deprecated basic configuration

Posted by Ruchith Fernando <ru...@gmail.com>.
On Tue, Feb 26, 2013 at 4:43 PM, Andreas Veithen
<an...@gmail.com> wrote:
> On Mon, Feb 4, 2013 at 11:02 PM, Ruchith Fernando
> <ru...@gmail.com> wrote:
>> Hi Andreas,
>>
>> Sorry ... my commit message is wrong!
>>
>> What I wanted to say was that I'm excluding them for now *until* those
>> are updated to use the policy based configuration.
>>
>> I was planning to work on this as and when I find time, and make sure
>> all those excluded test cases will be working again (hence I decided
>> to leave the configuration files as guidelines).
>>
>> If this is not ok, I'm more than willing to revert back to the
>> previous revision right now and will commit once I move all Rahas
>> testcases to policy config.
>
> Yes, I would definitely prefer that approach.

Done.

Thanks,
Ruchith

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org

Re: Rampart: Removing deprecated basic configuration

Posted by Andreas Veithen <an...@gmail.com>.
On Mon, Feb 4, 2013 at 11:02 PM, Ruchith Fernando
<ru...@gmail.com> wrote:
> Hi Andreas,
>
> Sorry ... my commit message is wrong!
>
> What I wanted to say was that I'm excluding them for now *until* those
> are updated to use the policy based configuration.
>
> I was planning to work on this as and when I find time, and make sure
> all those excluded test cases will be working again (hence I decided
> to leave the configuration files as guidelines).
>
> If this is not ok, I'm more than willing to revert back to the
> previous revision right now and will commit once I move all Rahas
> testcases to policy config.

Yes, I would definitely prefer that approach.

> Thanks,
> Ruchith
>
> On Mon, Feb 4, 2013 at 4:52 PM, Andreas Veithen
> <an...@gmail.com> wrote:
>> Ruchith,
>>
>> I'm in favor of eliminating the basic configuration. However, as you
>> have noticed, there were test cases using that configuration. From
>> what I see they not only test the configuration mechanism as such, but
>> also the underlying features. You simply removed them with the
>> following commit comment:
>>
>> "Excluded the Rahas tests from the integration tests to update them to
>> work with policy configuration."
>>
>> That doesn't make sense. One doesn't update test cases to use a
>> different configuration mechanism by simply removing them. The net
>> result of this is a reduction in code coverage primarily for the Rahas
>> module, as shown by the following coverage reports:
>>
>> http://people.apache.org/~veithen/jacoco-r1441297/
>> http://people.apache.org/~veithen/jacoco-r1441298/
>>
>> Considering that the code coverage is already quite low, I think that
>> this is not acceptable. Can you please ASAP propose something to
>> restore the code coverage?
>>
>> Andreas
>>
>>
>> On Thu, Jan 31, 2013 at 2:42 PM, Ruchith Fernando
>> <ru...@gmail.com> wrote:
>>> Hi Devs,
>>>
>>> Is anyone opposed to removing the deprecated (since rampart-1.1) basic
>>> configuration and just have one mode of configuration in Rampart?
>>>
>>> Thanks,
>>> Ruchith
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
>>> For additional commands, e-mail: java-dev-help@axis.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
>> For additional commands, e-mail: java-dev-help@axis.apache.org
>>
>
>
>
> --
> http://ruchith.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
> For additional commands, e-mail: java-dev-help@axis.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org

Re: Rampart: Removing deprecated basic configuration

Posted by Ruchith Fernando <ru...@gmail.com>.
Hi Andreas,

Sorry ... my commit message is wrong!

What I wanted to say was that I'm excluding them for now *until* those
are updated to use the policy based configuration.

I was planning to work on this as and when I find time, and make sure
all those excluded test cases will be working again (hence I decided
to leave the configuration files as guidelines).

If this is not ok, I'm more than willing to revert back to the
previous revision right now and will commit once I move all Rahas
testcases to policy config.

Thanks,
Ruchith

On Mon, Feb 4, 2013 at 4:52 PM, Andreas Veithen
<an...@gmail.com> wrote:
> Ruchith,
>
> I'm in favor of eliminating the basic configuration. However, as you
> have noticed, there were test cases using that configuration. From
> what I see they not only test the configuration mechanism as such, but
> also the underlying features. You simply removed them with the
> following commit comment:
>
> "Excluded the Rahas tests from the integration tests to update them to
> work with policy configuration."
>
> That doesn't make sense. One doesn't update test cases to use a
> different configuration mechanism by simply removing them. The net
> result of this is a reduction in code coverage primarily for the Rahas
> module, as shown by the following coverage reports:
>
> http://people.apache.org/~veithen/jacoco-r1441297/
> http://people.apache.org/~veithen/jacoco-r1441298/
>
> Considering that the code coverage is already quite low, I think that
> this is not acceptable. Can you please ASAP propose something to
> restore the code coverage?
>
> Andreas
>
>
> On Thu, Jan 31, 2013 at 2:42 PM, Ruchith Fernando
> <ru...@gmail.com> wrote:
>> Hi Devs,
>>
>> Is anyone opposed to removing the deprecated (since rampart-1.1) basic
>> configuration and just have one mode of configuration in Rampart?
>>
>> Thanks,
>> Ruchith
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
>> For additional commands, e-mail: java-dev-help@axis.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
> For additional commands, e-mail: java-dev-help@axis.apache.org
>



-- 
http://ruchith.org

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org

Re: Rampart: Removing deprecated basic configuration

Posted by Andreas Veithen <an...@gmail.com>.
Ruchith,

I'm in favor of eliminating the basic configuration. However, as you
have noticed, there were test cases using that configuration. From
what I see they not only test the configuration mechanism as such, but
also the underlying features. You simply removed them with the
following commit comment:

"Excluded the Rahas tests from the integration tests to update them to
work with policy configuration."

That doesn't make sense. One doesn't update test cases to use a
different configuration mechanism by simply removing them. The net
result of this is a reduction in code coverage primarily for the Rahas
module, as shown by the following coverage reports:

http://people.apache.org/~veithen/jacoco-r1441297/
http://people.apache.org/~veithen/jacoco-r1441298/

Considering that the code coverage is already quite low, I think that
this is not acceptable. Can you please ASAP propose something to
restore the code coverage?

Andreas


On Thu, Jan 31, 2013 at 2:42 PM, Ruchith Fernando
<ru...@gmail.com> wrote:
> Hi Devs,
>
> Is anyone opposed to removing the deprecated (since rampart-1.1) basic
> configuration and just have one mode of configuration in Rampart?
>
> Thanks,
> Ruchith
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
> For additional commands, e-mail: java-dev-help@axis.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org

Re: Rampart: Removing deprecated basic configuration

Posted by Sagara Gunathunga <sa...@gmail.com>.
+1

Thanks !

On Thu, Jan 31, 2013 at 7:12 PM, Ruchith Fernando
<ru...@gmail.com> wrote:
> Hi Devs,
>
> Is anyone opposed to removing the deprecated (since rampart-1.1) basic
> configuration and just have one mode of configuration in Rampart?
>
> Thanks,
> Ruchith
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
> For additional commands, e-mail: java-dev-help@axis.apache.org
>



-- 
Sagara Gunathunga

Blog      - http://ssagara.blogspot.com
Web      - http://people.apache.org/~sagara/
LinkedIn - http://www.linkedin.com/in/ssagara

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org