[GitHub] [calcite] chunweilei commented on a change in pull request #1560: [CALCITE-3478] Restructure tests for materialized views

[GitBox <gi...@apache.org>]

chunweilei commented on a change in pull request #1560: [CALCITE-3478] Restructure tests for materialized views
URL: https://github.com/apache/calcite/pull/1560#discussion_r356469016
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/mutable/MutableScan.java
 ##########
 @@ -36,11 +36,12 @@ public static MutableScan of(TableScan scan) {
   @Override public boolean equals(Object obj) {
     return obj == this
         || obj instanceof MutableScan
-        && rel.equals(((MutableScan) obj).rel);
+            && rel.getTable().getQualifiedName().equals(((MutableScan) obj).rel
+                .getTable().getQualifiedName());
   }
 
   @Override public int hashCode() {
-    return rel.hashCode();
+    return rel.getTable().getQualifiedName().hashCode();
   }
 
 Review comment:
   Is this change expected?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services