You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/08/24 02:40:40 UTC
[GitHub] [dubbo-go] chickenlj commented on a diff in pull request #2025: [WIP] Enable publish servicedefinition to metadata center
chickenlj commented on code in PR #2025:
URL: https://github.com/apache/dubbo-go/pull/2025#discussion_r953268369
##########
metadata/identifier/base_metadata_identifier.go:
##########
@@ -43,6 +43,9 @@ type BaseMetadataIdentifier struct {
func joinParams(joinChar string, params []string) string {
var joinedStr string
for _, param := range params {
+ if param == "" {
+ break
Review Comment:
Better add a log here to record this early return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org