You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/25 07:19:05 UTC

[GitHub] [pulsar-client-go] GPrabhudas commented on a change in pull request #552: Encryption support in Go client

GPrabhudas commented on a change in pull request #552:
URL: https://github.com/apache/pulsar-client-go/pull/552#discussion_r658529680



##########
File path: pulsar/consumer_impl.go
##########
@@ -25,9 +25,10 @@ import (
 	"sync"
 	"time"
 
+	"github.com/apache/pulsar-client-go/pulsar/crypto"
 	"github.com/apache/pulsar-client-go/pulsar/internal"
-	pb "github.com/apache/pulsar-client-go/pulsar/internal/pulsar_proto"
 	"github.com/apache/pulsar-client-go/pulsar/log"
+	pb "github.com/apache/pulsar-client-go/pulsar/pulsar_proto"

Review comment:
       Client need access to `MessagaMetada` if they do not want to use default implementation of crypto. And it is not possible unless we make it public. Let me check if I can create a wrapper on it and expose it instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org