[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #952: ioctl should check if int will fit in unsigned long not be exactly unsigned long

[GitBox <gi...@apache.org>]

patacongo commented on a change in pull request #952:
URL: https://github.com/apache/incubator-nuttx/pull/952#discussion_r419099694



##########
File path: libs/libc/misc/lib_ioctl.c
##########
@@ -91,7 +91,7 @@ int ioctl(int fd, int req, ...)
   /* Get the unsigned long argument.
    *
    * REVISIT:  This could be the cause of the crash down the road if the
-   * actual size of the argument is anything other than sizeof(unsigned long).
+   * actual size of the argument not sizeof(unsigned long).

Review comment:
       ```suggestion
      * actual size of the argument is not sizeof(unsigned long).
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org