You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "candiduslynx (via GitHub)" <gi...@apache.org> on 2023/06/06 17:38:46 UTC

[GitHub] [arrow] candiduslynx commented on a diff in pull request #35899: GH-35909: [Go] Deprecate `arrow.MapType.ValueField` & `arrow.MapType.ValueType` methods

candiduslynx commented on code in PR #35899:
URL: https://github.com/apache/arrow/pull/35899#discussion_r1220061910


##########
go/parquet/pqarrow/encode_arrow.go:
##########
@@ -36,19 +36,17 @@ import (
 
 // get the count of the number of leaf arrays for the type
 func calcLeafCount(dt arrow.DataType) int {
+	if dt, ok := dt.(arrow.ListLikeType); ok {
+		return calcLeafCount(dt.Elem())
+	}

Review Comment:
   Done in 9ce73c4a0e8ccbc0c1f0fdc632666df4dc947750.
   I removed the panic on the union types then (as they are nested, BTW).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org