You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/05/15 16:34:17 UTC
[GitHub] [orc] dongjoon-hyun opened a new pull request, #1494: ORC-1422: Setting version to 2.0.0-SNAPSHOT
dongjoon-hyun opened a new pull request, #1494:
URL: https://github.com/apache/orc/pull/1494
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #1494: ORC-1422: Setting version to 2.0.0-SNAPSHOT
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1494:
URL: https://github.com/apache/orc/pull/1494#issuecomment-1549523480
Thanks @dongjoon-hyun!
Should we stabilize the file version `UNSTABLE_PRE_2_0` as well?
https://github.com/apache/orc/blob/main/java/core/src/java/org/apache/orc/OrcFile.java#L79
https://github.com/apache/orc/blob/09cd71cd50eece97facfc002f82f7ce7e19a072e/c%2B%2B/src/Common.cc#L135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #1494: ORC-1422: Setting version to 2.0.0-SNAPSHOT
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1494:
URL: https://github.com/apache/orc/pull/1494#issuecomment-1550759205
That makes sense. Let us discuss it in the separate topic. @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1494: ORC-1422: Setting version to 2.0.0-SNAPSHOT
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1494:
URL: https://github.com/apache/orc/pull/1494#issuecomment-1550556830
Thank you, @williamhyun !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1494: ORC-1422: Setting version to 2.0.0-SNAPSHOT
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1494:
URL: https://github.com/apache/orc/pull/1494#issuecomment-1548273529
cc @williamhyun , @omalley , @wgtmac , @guiyanakuang , @pavibhai , @stiga-huang , @prasanthj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1494: ORC-1422: Setting version to 2.0.0-SNAPSHOT
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1494:
URL: https://github.com/apache/orc/pull/1494#issuecomment-1548912874
Thank you, @guiyanakuang !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1494: ORC-1422: Setting version to 2.0.0-SNAPSHOT
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1494:
URL: https://github.com/apache/orc/pull/1494#issuecomment-1550760959
Thank you. Yes, I'll send out the summary of AS-IS status via email soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1494: ORC-1422: Setting version to 2.0.0-SNAPSHOT
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1494:
URL: https://github.com/apache/orc/pull/1494#issuecomment-1550557128
Merged to main for Apache ORC 2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1494: ORC-1422: Setting version to 2.0.0-SNAPSHOT
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1494:
URL: https://github.com/apache/orc/pull/1494#issuecomment-1550119944
To @wgtmac , I filed a new issue for that because it needs more attentions before the official release of Apache ORC 2.0.
- https://github.com/apache/orc/issues/1499
We will revisit the ORC File Format v2.0 topic in the mailing list first.
Like Apache Parquet or Apache Arrow, I hope we split `ORC Format` from `ORC library`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1494: ORC-1422: Setting version to 2.0.0-SNAPSHOT
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1494:
URL: https://github.com/apache/orc/pull/1494#issuecomment-1548274364
Thank you, @pavibhai !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #1494: ORC-1422: Setting version to 2.0.0-SNAPSHOT
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #1494: ORC-1422: Setting version to 2.0.0-SNAPSHOT
URL: https://github.com/apache/orc/pull/1494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1494: ORC-1422: Setting version to 2.0.0-SNAPSHOT
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1494:
URL: https://github.com/apache/orc/pull/1494#issuecomment-1553584060
FYI, now we have `2.0.0-SNAPSHOT`.
- https://repository.apache.org/content/groups/snapshots/org/apache/orc/orc-core/2.0.0-SNAPSHOT/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1494: ORC-1422: Setting version to 2.0.0-SNAPSHOT
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1494:
URL: https://github.com/apache/orc/pull/1494#issuecomment-1549915961
Nice catch. Thank you, @wgtmac .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org