You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Denis A. (JIRA)" <de...@myfaces.apache.org> on 2010/09/01 11:38:55 UTC
[jira] Created: (TOMAHAWK-1544)
org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken when no
converter is used
org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken when no converter is used
--------------------------------------------------------------------------------------------
Key: TOMAHAWK-1544
URL: https://issues.apache.org/jira/browse/TOMAHAWK-1544
Project: MyFaces Tomahawk
Issue Type: Bug
Components: Date
Affects Versions: 1.1.9
Reporter: Denis A.
the problem is in the decoding of date:
if (token.startsWith("year="))
{
userData.setYear(token.substring(5));
}
if (token.startsWith("month="))
{
userData.setYear(token.substring(6));
}
if (token.startsWith("day="))
{
userData.setYear(token.substring(4));
.....
userData.setYear() is called for each case, while it should be setMonth(), setDay() and so on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-1544)
org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken when no
converter is used
Posted by "Denis A. (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Denis A. updated TOMAHAWK-1544:
-------------------------------
Status: Patch Available (was: Open)
> org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken when no converter is used
> --------------------------------------------------------------------------------------------
>
> Key: TOMAHAWK-1544
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1544
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Date
> Affects Versions: 1.1.9
> Reporter: Denis A.
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> the problem is in the decoding of date:
> if (token.startsWith("year="))
> {
> userData.setYear(token.substring(5));
> }
> if (token.startsWith("month="))
> {
> userData.setYear(token.substring(6));
> }
> if (token.startsWith("day="))
> {
> userData.setYear(token.substring(4));
> .....
> userData.setYear() is called for each case, while it should be setMonth(), setDay() and so on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TOMAHAWK-1544)
org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken
Posted by "Denis A. (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905563#action_12905563 ]
Denis A. edited comment on TOMAHAWK-1544 at 9/2/10 12:06 PM:
-------------------------------------------------------------
Core12 version is broken too, the provided patch does not address this one
was (Author: dangi):
Core12 version is broken, in the same way too, the provided patch does not address this one
> org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken
> ------------------------------------------------------------------
>
> Key: TOMAHAWK-1544
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1544
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Date
> Affects Versions: 1.1.9
> Reporter: Denis A.
> Attachments: TOMAHAWK-1544_bugfix_patch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> the problem is in the decoding of date:
> if (token.startsWith("year="))
> {
> userData.setYear(token.substring(5));
> }
> if (token.startsWith("month="))
> {
> userData.setYear(token.substring(6));
> }
> if (token.startsWith("day="))
> {
> userData.setYear(token.substring(4));
> .....
> userData.setYear() is called for each case, while it should be setMonth(), setDay() and so on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1544)
org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken when no
converter is used
Posted by "Denis A. (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904997#action_12904997 ]
Denis A. commented on TOMAHAWK-1544:
------------------------------------
TOMAHAWK-1544_bugfix_patch.txt is not enough to make t:inputDate work without a converter, it seems there are other bugs in HtmlDateRenderer
> org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken when no converter is used
> --------------------------------------------------------------------------------------------
>
> Key: TOMAHAWK-1544
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1544
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Date
> Affects Versions: 1.1.9
> Reporter: Denis A.
> Attachments: TOMAHAWK-1544_bugfix_patch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> the problem is in the decoding of date:
> if (token.startsWith("year="))
> {
> userData.setYear(token.substring(5));
> }
> if (token.startsWith("month="))
> {
> userData.setYear(token.substring(6));
> }
> if (token.startsWith("day="))
> {
> userData.setYear(token.substring(4));
> .....
> userData.setYear() is called for each case, while it should be setMonth(), setDay() and so on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-1544)
org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken when no
converter is used
Posted by "Denis A. (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Denis A. updated TOMAHAWK-1544:
-------------------------------
Status: Patch Available (was: Open)
> org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken when no converter is used
> --------------------------------------------------------------------------------------------
>
> Key: TOMAHAWK-1544
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1544
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Date
> Affects Versions: 1.1.9
> Reporter: Denis A.
> Attachments: TOMAHAWK-1544_bugfix_patch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> the problem is in the decoding of date:
> if (token.startsWith("year="))
> {
> userData.setYear(token.substring(5));
> }
> if (token.startsWith("month="))
> {
> userData.setYear(token.substring(6));
> }
> if (token.startsWith("day="))
> {
> userData.setYear(token.substring(4));
> .....
> userData.setYear() is called for each case, while it should be setMonth(), setDay() and so on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-1544)
org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe updated TOMAHAWK-1544:
-------------------------------------
Status: Resolved (was: Patch Available)
Assignee: Leonardo Uribe
Fix Version/s: 1.1.10-SNAPSHOT
Resolution: Fixed
Thanks to Denis A. for provide this patch.
> org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken
> ------------------------------------------------------------------
>
> Key: TOMAHAWK-1544
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1544
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Date
> Affects Versions: 1.1.9
> Reporter: Denis A.
> Assignee: Leonardo Uribe
> Fix For: 1.1.10-SNAPSHOT
>
> Attachments: TOMAHAWK-1544_bugfix_patch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> the problem is in the decoding of date:
> if (token.startsWith("year="))
> {
> userData.setYear(token.substring(5));
> }
> if (token.startsWith("month="))
> {
> userData.setYear(token.substring(6));
> }
> if (token.startsWith("day="))
> {
> userData.setYear(token.substring(4));
> .....
> userData.setYear() is called for each case, while it should be setMonth(), setDay() and so on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-1544)
org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken when no
converter is used
Posted by "Denis A. (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Denis A. updated TOMAHAWK-1544:
-------------------------------
Status: Open (was: Patch Available)
> org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken when no converter is used
> --------------------------------------------------------------------------------------------
>
> Key: TOMAHAWK-1544
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1544
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Date
> Affects Versions: 1.1.9
> Reporter: Denis A.
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> the problem is in the decoding of date:
> if (token.startsWith("year="))
> {
> userData.setYear(token.substring(5));
> }
> if (token.startsWith("month="))
> {
> userData.setYear(token.substring(6));
> }
> if (token.startsWith("day="))
> {
> userData.setYear(token.substring(4));
> .....
> userData.setYear() is called for each case, while it should be setMonth(), setDay() and so on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-1544)
org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken when no
converter is used
Posted by "Denis A. (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905009#action_12905009 ]
Denis A. commented on TOMAHAWK-1544:
------------------------------------
problematic code seems to have been added in the following commits:
r745285 | lu4242 | 2009-02-17 23:52:58 CET
TOMAHAWK-1014 HTMLInputDate ignores custom converters
----------------------------------------------------------------------------
r745124 | lu4242 | 2009-02-17 16:42:47 CET
TOMAHAWK-1014 HTMLInputDate ignores custom converters (changed decode and encodeEnd so converters can be set).
----------------------------------------------------------------------------
as a result there is always a DateTimeConverter, but if converter="" is not specified the t:inputDate fail on the validation step
> org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken when no converter is used
> --------------------------------------------------------------------------------------------
>
> Key: TOMAHAWK-1544
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1544
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Date
> Affects Versions: 1.1.9
> Reporter: Denis A.
> Attachments: TOMAHAWK-1544_bugfix_patch.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> the problem is in the decoding of date:
> if (token.startsWith("year="))
> {
> userData.setYear(token.substring(5));
> }
> if (token.startsWith("month="))
> {
> userData.setYear(token.substring(6));
> }
> if (token.startsWith("day="))
> {
> userData.setYear(token.substring(4));
> .....
> userData.setYear() is called for each case, while it should be setMonth(), setDay() and so on.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.