You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/24 09:28:07 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #11110:
[FLINK-16111][k8s] Fix Kubernetes deployment not respecting
'taskmanager.cpu.cores'.
azagrebin commented on a change in pull request #11110: [FLINK-16111][k8s] Fix Kubernetes deployment not respecting 'taskmanager.cpu.cores'.
URL: https://github.com/apache/flink/pull/11110#discussion_r383151412
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManager.java
##########
@@ -338,6 +339,7 @@ protected FlinkKubeClient createFlinkKubeClient() {
@Override
protected double getCpuCores(Configuration configuration) {
- return flinkConfig.getDouble(KubernetesConfigOptions.TASK_MANAGER_CPU, numSlotsPerTaskManager);
+ double fallback = configuration.getDouble(KubernetesConfigOptions.TASK_MANAGER_CPU);
+ return TaskExecutorProcessUtils.getCpuCoresWithFallback(configuration, fallback).getValue().doubleValue();
Review comment:
I think this is difficult to unify among all active RMs, because we do operations over concrete number types in `getCpuCoresWithFallback` and yarn fallback option is Integer but others are double.
We could have one more shortcut for double though for Mesos/K8s:
```
public static CPUResource getCpuCoresWithFallback(final Configuration config, ConfigOption<Double> fallback)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services