You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/29 17:17:04 UTC
[jira] [Commented] (SOLR-11508) core.properties should be stored
$solr.data.home/$core.name
[ https://issues.apache.org/jira/browse/SOLR-11508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271146#comment-16271146 ]
ASF GitHub Bot commented on SOLR-11508:
---------------------------------------
GitHub user morissm opened a pull request:
https://github.com/apache/lucene-solr/pull/278
SOLR-11508: core.properties should be stored $solr.data.home/core_name
I ended up simply defaulting coreRootDirectory to solr.data.home, if it is defined, and solr.home.home otherwise.
Both values seem somewhat redundant but comments in SOLR-6671 indicate that others have reasons to keep them separate. This patch simply makes Solr behave in a way that is more intuitive by default.
Those who need to revert to the old way can define coreRootDirectory in solr.xml, if they hadn't already.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/morissm/lucene-solr jira/solr-11508
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/278.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #278
----
commit bb6795aa69b60d161e2226e1f4a9338199612edd
Author: Marc-Andre Morissette <ma...@gmail.com>
Date: 2017-11-29T16:46:09Z
SOLR-11508: core.properties should be stored $solr.data.home/core_name
----
> core.properties should be stored $solr.data.home/$core.name
> -----------------------------------------------------------
>
> Key: SOLR-11508
> URL: https://issues.apache.org/jira/browse/SOLR-11508
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Marc Morissette
>
> Since Solr 7, it is possible to store Solr cores in separate disk locations using solr.data.home (see SOLR-6671). This is very useful where running Solr in Docker where data must be stored in a directory which is independent from the rest of the container.
> Unfortunately, while core data is stored in {{$\{solr.data.home}/$\{core.name}/index/...}}, core.properties is stored in {{$\{solr.solr.home}/$\{core.name}/core.properties}}.
> Reading SOLR-6671 comments, I think this was the expected behaviour but I don't think it is the correct one.
> In addition to being inelegant and counterintuitive, this has the drawback of stripping a core of its metadata and breaking core discovery when a Solr installation is redeployed, whether in Docker or not.
> core.properties is mostly metadata and although it contains some configuration, this configuration is specific to the core it accompanies. I believe it should be stored in solr.data.home, with the rest of the data it describes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org