You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/08/24 09:30:18 UTC
Review Request 68497: Added --skip-verify flag to verify-reviews.py
to skip verification
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
Repository: mesos
Description
-------
Added --skip-verify flag to verify-reviews.py to skip verification altogether, and just print or write to file the review ids that need verification.
Diffs
-----
support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb
Diff: https://reviews.apache.org/r/68497/diff/1/
Testing
-------
python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password
Thanks,
Dragos Schebesch
Re: Review Request 68497: Added --skip-verify flag to
verify-reviews.py to skip verification
Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.
> On Aug. 24, 2018, 9:40 a.m., Benjamin Bannier wrote:
> > I like the idea to make more traceable what would be verified.
> >
> > That said, thinking about a script called `verify-reviews.py` with a flag called `--no-verify` made me slightly dizzy :D. Could what you are after also be accomplished by a `--dry-run` option? That one would, at least to me, both have more straight-forward semantics, and potentially allow wider use cases. We have such a flag in `support/apply-reviews.py` already where it is very useful.
We would use this option in our CI pipeline in order to batch process the review IDs that need verification in Jenkins. This helps us spawn multiple jobs in parallel and is a part of how our CI for mesos is setup right now.
I've thought about naming it --dry-run as well, but I figured we only need to print some review IDs, something like --dry-run would print other stuff too, which would defeat the purpose for what we're trying to accomplish.
- Dragos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/#review207862
-----------------------------------------------------------
On Aug. 24, 2018, 9:30 a.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68497/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 9:30 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added --skip-verify flag to verify-reviews.py to skip verification altogether, and just print or write to file the review ids that need verification.
>
>
> Diffs
> -----
>
> support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb
>
>
> Diff: https://reviews.apache.org/r/68497/diff/1/
>
>
> Testing
> -------
>
> python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password
>
>
> Thanks,
>
> Dragos Schebesch
>
>
Re: Review Request 68497: Added --skip-verify flag to
verify-reviews.py to skip verification
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/#review207862
-----------------------------------------------------------
I like the idea to make more traceable what would be verified.
That said, thinking about a script called `verify-reviews.py` with a flag called `--no-verify` made me slightly dizzy :D. Could what you are after also be accomplished by a `--dry-run` option? That one would, at least to me, both have more straight-forward semantics, and potentially allow wider use cases. We have such a flag in `support/apply-reviews.py` already where it is very useful.
- Benjamin Bannier
On Aug. 24, 2018, 11:30 a.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68497/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 11:30 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added --skip-verify flag to verify-reviews.py to skip verification altogether, and just print or write to file the review ids that need verification.
>
>
> Diffs
> -----
>
> support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb
>
>
> Diff: https://reviews.apache.org/r/68497/diff/1/
>
>
> Testing
> -------
>
> python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password
>
>
> Thanks,
>
> Dragos Schebesch
>
>
Re: Review Request 68497: Added --skip-verify flag to
verify-reviews.py to
skip verification altogether and just print or write to file the review ids
that need verification.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/#review207866
-----------------------------------------------------------
PASS: Mesos patch 68497 was successfully built and tested.
Reviews applied: `['68497']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2231/mesos-review-68497
- Mesos Reviewbot Windows
On Aug. 24, 2018, 9:47 a.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68497/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 9:47 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added --skip-verify flag to verify-reviews.py to skip verification altogether and just print or write to file the review ids that need verification.
>
>
> Diffs
> -----
>
> support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb
>
>
> Diff: https://reviews.apache.org/r/68497/diff/2/
>
>
> Testing
> -------
>
> python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password
>
>
> Thanks,
>
> Dragos Schebesch
>
>
Re: Review Request 68497: Added --skip-verify flag to
verify-reviews.py to skip verification.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/#review207881
-----------------------------------------------------------
PASS: Mesos patch 68497 was successfully built and tested.
Reviews applied: `['68497']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2233/mesos-review-68497
- Mesos Reviewbot Windows
On Aug. 24, 2018, 1:40 p.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68497/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 1:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows devs to skip verification and just print or
> write to a file the review ids that need verification.
>
>
> Diffs
> -----
>
> support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb
>
>
> Diff: https://reviews.apache.org/r/68497/diff/4/
>
>
> Testing
> -------
>
> python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password
>
>
> Thanks,
>
> Dragos Schebesch
>
>
Re: Review Request 68497: Added --skip-verify flag to
verify-reviews.py to skip verification.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/#review207878
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On Aug. 24, 2018, 3:40 p.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68497/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 3:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows devs to skip verification and just print or
> write to a file the review ids that need verification.
>
>
> Diffs
> -----
>
> support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb
>
>
> Diff: https://reviews.apache.org/r/68497/diff/4/
>
>
> Testing
> -------
>
> python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password
>
>
> Thanks,
>
> Dragos Schebesch
>
>
Re: Review Request 68497: Added --skip-verify flag to
verify-reviews.py to skip verification.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/#review207880
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68497]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 24, 2018, 1:40 p.m., Dragos Schebesch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68497/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 1:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows devs to skip verification and just print or
> write to a file the review ids that need verification.
>
>
> Diffs
> -----
>
> support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb
>
>
> Diff: https://reviews.apache.org/r/68497/diff/4/
>
>
> Testing
> -------
>
> python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password
>
>
> Thanks,
>
> Dragos Schebesch
>
>
Re: Review Request 68497: Added --skip-verify flag to
verify-reviews.py to skip verification.
Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/
-----------------------------------------------------------
(Updated Aug. 24, 2018, 1:40 p.m.)
Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
Summary (updated)
-----------------
Added --skip-verify flag to verify-reviews.py to skip verification.
Repository: mesos
Description (updated)
-------
This flag allows devs to skip verification and just print or
write to a file the review ids that need verification.
Diffs (updated)
-----
support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb
Diff: https://reviews.apache.org/r/68497/diff/4/
Changes: https://reviews.apache.org/r/68497/diff/3-4/
Testing
-------
python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password
Thanks,
Dragos Schebesch
Re: Review Request 68497: Added --skip-verify flag to
verify-reviews.py to
skip verification and just print or write to file the review ids that need
verification.
Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/
-----------------------------------------------------------
(Updated Aug. 24, 2018, 12:22 p.m.)
Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
Summary (updated)
-----------------
Added --skip-verify flag to verify-reviews.py to skip verification and just print or write to file the review ids that need verification.
Repository: mesos
Description (updated)
-------
Added --skip-verify flag to verify-reviews.py to skip verification
and just print or write to file the review ids that need verification.
Diffs (updated)
-----
support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb
Diff: https://reviews.apache.org/r/68497/diff/3/
Changes: https://reviews.apache.org/r/68497/diff/2-3/
Testing
-------
python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password
Thanks,
Dragos Schebesch
Re: Review Request 68497: Added --skip-verify flag to
verify-reviews.py to
skip verification altogether and just print or write to file the review ids
that need verification.
Posted by Dragos Schebesch via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68497/
-----------------------------------------------------------
(Updated Aug. 24, 2018, 9:47 a.m.)
Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
Summary (updated)
-----------------
Added --skip-verify flag to verify-reviews.py to skip verification altogether and just print or write to file the review ids that need verification.
Repository: mesos
Description (updated)
-------
Added --skip-verify flag to verify-reviews.py to skip verification altogether and just print or write to file the review ids that need verification.
Diffs (updated)
-----
support/python3/verify-reviews.py 14e5f9bf512732cb6705e7484efd86e2838287bb
Diff: https://reviews.apache.org/r/68497/diff/2/
Changes: https://reviews.apache.org/r/68497/diff/1-2/
Testing
-------
python3 ./support/python3/verify-reviews.py --skip-verify -u $user -p $password
Thanks,
Dragos Schebesch