You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/01 14:45:53 UTC

[GitHub] [kafka] mimaison commented on a change in pull request #10459: KAFKA-12601: Remove deprecated `delegation.token.master.key` in 3.0

mimaison commented on a change in pull request #10459:
URL: https://github.com/apache/kafka/pull/10459#discussion_r605716048



##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1292,8 +1290,7 @@ object KafkaConfig {
       .define(SaslLoginRefreshMinPeriodSecondsProp, SHORT, Defaults.SaslLoginRefreshMinPeriodSeconds, MEDIUM, SaslLoginRefreshMinPeriodSecondsDoc)
       .define(SaslLoginRefreshBufferSecondsProp, SHORT, Defaults.SaslLoginRefreshBufferSeconds, MEDIUM, SaslLoginRefreshBufferSecondsDoc)
       /** ********* Delegation Token Configuration ****************/
-      .define(DelegationTokenSecretKeyAliasProp, PASSWORD, null, MEDIUM, DelegationTokenSecretKeyAliasDoc)
-      .define(DelegationTokenSecretKeyProp, PASSWORD, null, MEDIUM, DelegationTokenSecretKeyDoc)
+      .define(DelegationTokenSecretKeyProp, PASSWORD, MEDIUM, DelegationTokenSecretKeyDoc)

Review comment:
       It looks like some logic depends on having `null` as default as a bunch of tests are failing with:
   ```
   org.apache.kafka.common.config.ConfigException: Missing required configuration "delegation.token.secret.key" which has no default value.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org