[GitHub] ccollins476ad commented on a change in pull request #933: sys/log: Better handling for long/non-text entries

[GitBox <gi...@apache.org>]

ccollins476ad commented on a change in pull request #933: sys/log: Better handling for long/non-text entries
URL: https://github.com/apache/mynewt-core/pull/933#discussion_r178914167
 
 

 ##########
 File path: sys/log/full/src/log.c
 ##########
 @@ -62,7 +62,7 @@ log_init(void)
     log_inited = 1;
     log_written = 0;
 
-    g_log_info.li_version = LOG_VERSION_V2;
+    g_log_info.li_version = LOG_VERSION_V3;
 
 Review comment:
   Should this be:
   ```
   g_log_info.li_version = MYNEWT_VAL(LOG_VERSION);
   ```
   ?
   
   Actually, I am not sure I understand why we even need `g_log_info.li_version`.  Can we just use `MYNEWT_VAL(LOG_VERSION)` instead?  I might have missed something in the code, so feel free to correct me :).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services