You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by evans-ye <gi...@git.apache.org> on 2016/01/17 07:48:46 UTC
[GitHub] bigtop pull request: BIGTOP-2254. Replace the Docker orchestration...
GitHub user evans-ye opened a pull request:
https://github.com/apache/bigtop/pull/71
BIGTOP-2254. Replace the Docker orchestration tool from Vagrant to Do…
…cker Compose
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/evans-ye/bigtop BIGTOP-2254
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit 89b64afff5b20a3f071b91ea39c60bd266ff5ae7
Author: Evans Ye <ev...@apache.org>
Date: 2016-01-17T06:36:35Z
BIGTOP-2254. Replace the Docker orchestration tool from Vagrant to Docker Compose
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2254. Replace the Docker orchestration...
Posted by evans-ye <gi...@git.apache.org>.
Github user evans-ye closed the pull request at:
https://github.com/apache/bigtop/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2254. Replace the Docker orchestration...
Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on the pull request:
https://github.com/apache/bigtop/pull/71#issuecomment-172649679
I will start looking at it in a day or two as soon as I am done with a couple of things in the woodworks right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: BIGTOP-2254. Replace the Docker orchestration...
Posted by evans-ye <gi...@git.apache.org>.
Github user evans-ye commented on the pull request:
https://github.com/apache/bigtop/pull/71#issuecomment-173178445
Thanks for the review!
Yes you should have docker-compose installed first. I plan to add support to download and install it via docker-hadoop as well. After all it just need one line to get it done. :)
config/hieradata will be generated in generate-config function. In the future we should allow users to specify customized config instead of always generate new ones.
The new directory is a very good idea. I was digging to deep so that I can't see the name is so misleading... With that we can just merge it into master w/o breaking anything.
In fact, I'm thinking that maybe we can put a top level directory for provisioners. That things currently sit inside bigtop-deploy is hard to find. What do you think?
BTW, any shell script styling comment is welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---