[jira] [Commented] (LUCENE-6405) BaseXXXFormatTestCase should test exception handling.

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483619#comment-14483619 ] 

Robert Muir commented on LUCENE-6405:
-------------------------------------

False alarm (fake IOE -> slowFileExists == false -> scary assertion). I disable it during commit (with a comment) as a workaround. But its still on during reopen which does not have this check. I think its good enough.

> BaseXXXFormatTestCase should test exception handling.
> -----------------------------------------------------
>
>                 Key: LUCENE-6405
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6405
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Robert Muir
>         Attachments: LUCENE-6405_initial.patch
>
>
> BaseXXXFormatTestCases do a really good job on almost everything about testing a format. We rely on this almost completely for maintaining e.g. backwards compat codecs and keeping bugs out of the current ones.
> But they don't test the exception handling. For the current codecs you shouldn't have to debug testThreadInterruptDeadLock or similar. And for the back compat codecs, its just completely untested.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org