You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/04/04 16:41:00 UTC
[jira] [Work logged] (BEAM-6441) cut_release_branch.sh should not
push to master without verification and a PR
[ https://issues.apache.org/jira/browse/BEAM-6441?focusedWorklogId=223095&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223095 ]
ASF GitHub Bot logged work on BEAM-6441:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/19 16:40
Start Date: 04/Apr/19 16:40
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #8223: [BEAM-6441] Revise release branch cut instructions
URL: https://github.com/apache/beam/pull/8223
The current release branch cut script pushes to both the release branch and master without verification. The useful logic it encapsulates is simply the locations where we depend on the version. I have moved those into a `set_version.sh` script, and the remaining trivial steps are just git commands.
Since you are currently doing the release, how does this sound?
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) <br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/) | --- | --- | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 223095)
Time Spent: 10m
Remaining Estimate: 0h
> cut_release_branch.sh should not push to master without verification and a PR
> -----------------------------------------------------------------------------
>
> Key: BEAM-6441
> URL: https://issues.apache.org/jira/browse/BEAM-6441
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Labels: triaged
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, the cut_release_branch.sh does many things:
> - Edits files in place to update the version
> - Makes a local commit
> - Pushing the local commit to master
> - Creates a new branch
> - Edits files in place to update the version
> - Pushes the release branch
> I think all of this except the push to master are OK. It is possible that we have something - website, examples, new places where the version is hardcoded, etc, that get broken in this process. Moving from x-SNAPSHOT to (x+1)-SNAPSHOT is easy to do in a pull request and safe. The release branch creation does not need to be synchronized with this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)